Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] 기존의 UrlLiteral 을 없애고 info.plist 에 baseUrl 숨기기 #387

Closed
wants to merge 11 commits into from
Closed

[CHORE] 기존의 UrlLiteral 을 없애고 info.plist 에 baseUrl 숨기기 #387

wants to merge 11 commits into from

Conversation

seongmin221
Copy link
Collaborator

🌁 Background

기존에 UrlLiteral 은 너무 url 들을 공개 해두는 스타일이라 보안 문제가 있다고 생각이 들었습니다 !
솝트에서 배운 방법으로 url 을 info.plist 쪽에다가 숨기기로 했답니닷
(근데 클론받으면 어차피 거기서 거기 아닌가... 싶긴 한데... 아닌가 ??)

📱 Screenshot

👩‍💻 Contents

✅ Testing

브랜치로 오셔서 잘 돌아가는지 확인 해주세요 !!

📝 Review Note

📣 Related Issue

📬 Reference

@seongmin221 seongmin221 added 🛠 Chore 크진 않지만 무언가를 수정했다 📡 API API관련 코드를 작성했다 labels May 25, 2023
@seongmin221 seongmin221 self-assigned this May 25, 2023
@auto-assign auto-assign bot requested review from dangsal, Guel-git, hwiwonK and MMMIIIN May 25, 2023 14:29
@dangsal
Copy link
Collaborator

dangsal commented May 26, 2023 •
edited
Loading

url을 숨기고 나서 plist를 이제 깃 이그노어로 설정해야해요! 그래야 숨기는 과정이 이루어집니당

그런데 깃 이그노어를 중간에 이미 깃에 올라와있는것을 이그노어 할 수 없는걸로 알고있는데 (된다면 그냥 이그노어 추가하면 될거같고)
안된다면 plist를 새로 추가해서 이그노어에 추가해야할거같네요

Guel-git
Guel-git reviewed May 26, 2023
View reviewed changes
Copy link
Collaborator

@Guel-git Guel-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오이~ 생각보다 URLLiteral 사용하는 곳이 많군요 ㅋㅋㅋㅋ
호야의 말처럼 plist 가 ignore 되어야 할 것 같네용 !

Guel-git
Guel-git approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@Guel-git Guel-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 좋은 방법이네요 !
이드와 호야의 케미 좋네요 ㅋㅋ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guel-git Guel-git Guel-git approved these changes

@dangsal dangsal Awaiting requested review from dangsal

@hwiwonK hwiwonK Awaiting requested review from hwiwonK

@MMMIIIN MMMIIIN Awaiting requested review from MMMIIIN

Assignees

@seongmin221 seongmin221

Labels
📡 API API관련 코드를 작성했다 🛠 Chore 크진 않지만 무언가를 수정했다
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CHORE] 공개되어 있는 baseURL 숨기기
3 participants
@seongmin221 @dangsal @Guel-git