diff --git a/.semaphore/semaphore.yml b/.semaphore/semaphore.yml index f966088..4a3fbc2 100644 --- a/.semaphore/semaphore.yml +++ b/.semaphore/semaphore.yml @@ -10,14 +10,15 @@ blocks: jobs: - name: Build commands: - - 'wget https://dl.google.com/android/repository/commandlinetools-linux-6514223_latest.zip -O ~/android-commandline-tools.zip ' - - mkdir -p ~/android-sdk/cmdline-tools/ - - unzip ~/android-commandline-tools.zip -d ~/android-sdk/cmdline-tools - - 'export PATH=$PATH:~/android-sdk/cmdline-tools/tools/bin' - - yes | sdkmanager "ndk;21.4.7075529" - - 'export PATH=$PATH:~/android-sdk/ndk/21.4.7075529/' + - wget https://dl.google.com/android/repository/commandlinetools-linux-7583922_latest.zip -O ~/android-commandline-tools.zip + - mkdir -p ~/android-sdk/ + - unzip ~/android-commandline-tools.zip -d ~/android-sdk/cmdline-tools/ + - mv ~/android-sdk/cmdline-tools/cmdline-tools/ ~/android-sdk/cmdline-tools/latest + - export PATH=$PATH:~/android-sdk/cmdline-tools/latest/bin + - yes | sdkmanager "ndk;23.0.7599858" + - export PATH=$PATH:~/android-sdk/ndk/23.0.7599858/ - export ANDROID_SDK_ROOT=~/android-sdk - checkout - - sem-version java 1.8 + - sem-version java 11 - ./gradlew build - artifact push job app/build/outputs/apk/release/app-release.apk diff --git a/app/build.gradle b/app/build.gradle index c50a2f1..909d545 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -11,7 +11,7 @@ buildscript { } android { - compileSdkVersion 30 + compileSdkVersion 31 signingConfigs { debug { @@ -26,7 +26,7 @@ android { minSdkVersion 16 targetSdkVersion 30 versionCode 10 - versionName "2.4.7" + versionName "2.4.8" applicationId "jp.co.cyberagent.stf" } diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 81fbcfd..efba1f4 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -2,6 +2,7 @@ xmlns:tools="http://schemas.android.com/tools" package="jp.co.cyberagent.stf"> + @@ -18,6 +19,13 @@ + + + + + + + supplier ) { } } + @SuppressLint("MissingPermission") @Override protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); @@ -76,11 +78,10 @@ protected void onCreate(Bundle savedInstanceState) { layout.addView(createData(tm.getSimOperatorName())); layout.addView(createLabel("PHONE")); layout.addView(createData(getSecuredId(tm::getLine1Number))); - layout.addView(createLabel("IMEI")); - layout.addView(createData(getSecuredId(tm::getLine1Number))); - layout.addView(createLabel("ICCID")); - layout.addView(createData(getSecuredId(tm::getLine1Number))); - + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { + layout.addView(createLabel("IMEI")); + layout.addView(createData(getSecuredId(tm::getImei))); + } requestWindowFeature(Window.FEATURE_NO_TITLE); ensureVisibility(); diff --git a/app/src/main/java/jp/co/cyberagent/stf/Service.java b/app/src/main/java/jp/co/cyberagent/stf/Service.java index 70af29a..da021d6 100644 --- a/app/src/main/java/jp/co/cyberagent/stf/Service.java +++ b/app/src/main/java/jp/co/cyberagent/stf/Service.java @@ -46,6 +46,7 @@ import jp.co.cyberagent.stf.query.DoIdentifyResponder; import jp.co.cyberagent.stf.query.DoRemoveAccountResponder; import jp.co.cyberagent.stf.query.GetAccountsResponder; +import jp.co.cyberagent.stf.query.GetBluetoothStatusResponder; import jp.co.cyberagent.stf.query.GetBrowsersResponder; import jp.co.cyberagent.stf.query.GetClipboardResponder; import jp.co.cyberagent.stf.query.GetDisplayResponder; @@ -55,14 +56,13 @@ import jp.co.cyberagent.stf.query.GetSdStatusResponder; import jp.co.cyberagent.stf.query.GetVersionResponder; import jp.co.cyberagent.stf.query.GetWifiStatusResponder; -import jp.co.cyberagent.stf.query.GetBluetoothStatusResponder; +import jp.co.cyberagent.stf.query.SetBluetoothEnabledResponder; import jp.co.cyberagent.stf.query.SetClipboardResponder; import jp.co.cyberagent.stf.query.SetKeyguardStateResponder; import jp.co.cyberagent.stf.query.SetMasterMuteResponder; import jp.co.cyberagent.stf.query.SetRingerModeResponder; import jp.co.cyberagent.stf.query.SetWakeLockResponder; import jp.co.cyberagent.stf.query.SetWifiEnabledResponder; -import jp.co.cyberagent.stf.query.SetBluetoothEnabledResponder; public class Service extends android.app.Service { public static final String ACTION_START = "jp.co.cyberagent.stf.ACTION_START"; @@ -72,6 +72,7 @@ public class Service extends android.app.Service { private static final String TAG = "STFService"; private static final int NOTIFICATION_ID = 0x1; + private static final int PENDING_INTENT_FLAG = Build.VERSION.SDK_INT >= Build.VERSION_CODES.M ? PendingIntent.FLAG_IMMUTABLE : 0; private List monitors = new ArrayList(); private ExecutorService executor = Executors.newCachedThreadPool(); @@ -122,7 +123,7 @@ public void onCreate() { .setTicker(getString(R.string.service_ticker)) .setContentTitle(getString(R.string.service_title)) .setContentText(getString(R.string.service_text)) - .setContentIntent(PendingIntent.getActivity(this, 0, notificationIntent, 0)) + .setContentIntent(PendingIntent.getActivity(this, 0, notificationIntent, PENDING_INTENT_FLAG)) .setWhen(System.currentTimeMillis()) .build(); diff --git a/app/src/main/java/jp/co/cyberagent/stf/query/GetClipboardResponder.java b/app/src/main/java/jp/co/cyberagent/stf/query/GetClipboardResponder.java index 80013b0..394a276 100644 --- a/app/src/main/java/jp/co/cyberagent/stf/query/GetClipboardResponder.java +++ b/app/src/main/java/jp/co/cyberagent/stf/query/GetClipboardResponder.java @@ -64,26 +64,20 @@ public void cleanup() { } private CharSequence getClipboardText() { - if (Build.VERSION.SDK_INT >= 11) { - android.content.ClipboardManager clipboardManager = - (android.content.ClipboardManager) Service.getClipboardManager(); - if (clipboardManager.hasPrimaryClip()) { - ClipData clipData = clipboardManager.getPrimaryClip(); - if (clipData.getItemCount() > 0) { - ClipData.Item clip = clipData.getItemAt(0); - return clip.coerceToText(context.getApplicationContext()); - } - else { - return null; - } + android.content.ClipboardManager clipboardManager = + (android.content.ClipboardManager) Service.getClipboardManager(); + if (clipboardManager.hasPrimaryClip()) { + ClipData clipData = clipboardManager.getPrimaryClip(); + if (clipData.getItemCount() > 0) { + ClipData.Item clip = clipData.getItemAt(0); + return clip.coerceToText(context.getApplicationContext()); } else { return null; } } else { - return ((android.text.ClipboardManager) Service.getClipboardManager()) - .getText(); + return null; } } } diff --git a/app/src/main/java/jp/co/cyberagent/stf/query/GetPropertiesResponder.java b/app/src/main/java/jp/co/cyberagent/stf/query/GetPropertiesResponder.java index 83a0075..0e0d956 100644 --- a/app/src/main/java/jp/co/cyberagent/stf/query/GetPropertiesResponder.java +++ b/app/src/main/java/jp/co/cyberagent/stf/query/GetPropertiesResponder.java @@ -1,5 +1,6 @@ package jp.co.cyberagent.stf.query; +import android.annotation.SuppressLint; import android.content.Context; import android.os.Build; import android.telephony.TelephonyManager; @@ -21,6 +22,7 @@ public GetPropertiesResponder(Context context) { super(context); } + @SuppressLint("MissingPermission") //fall back to nulls on newer Android versions @Override public GeneratedMessageLite respond(Wire.Envelope envelope) throws InvalidProtocolBufferException { Wire.GetPropertiesRequest request = diff --git a/app/src/main/java/jp/co/cyberagent/stf/query/GetSdStatusResponder.java b/app/src/main/java/jp/co/cyberagent/stf/query/GetSdStatusResponder.java index 1f30542..067494a 100644 --- a/app/src/main/java/jp/co/cyberagent/stf/query/GetSdStatusResponder.java +++ b/app/src/main/java/jp/co/cyberagent/stf/query/GetSdStatusResponder.java @@ -59,10 +59,8 @@ public GeneratedMessageLite respond(Wire.Envelope envelope) throws InvalidProtoc } } - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.GINGERBREAD) { - if (!Environment.isExternalStorageRemovable()) { - mountList.remove(Environment.getExternalStorageDirectory().getPath()); - } + if (!Environment.isExternalStorageRemovable()) { + mountList.remove(Environment.getExternalStorageDirectory().getPath()); } for (int i = 0; i < mountList.size(); i++) { diff --git a/app/src/main/java/jp/co/cyberagent/stf/query/SetBluetoothEnabledResponder.java b/app/src/main/java/jp/co/cyberagent/stf/query/SetBluetoothEnabledResponder.java index e4cfc6a..cbe1ffb 100644 --- a/app/src/main/java/jp/co/cyberagent/stf/query/SetBluetoothEnabledResponder.java +++ b/app/src/main/java/jp/co/cyberagent/stf/query/SetBluetoothEnabledResponder.java @@ -26,13 +26,16 @@ public GeneratedMessageLite respond(Wire.Envelope envelope) throws InvalidProtoc if (bm != null) { BluetoothAdapter ba = bm.getAdapter(); if (ba != null) { - if (request.getEnabled()) { - ba.enable(); + try { + if (request.getEnabled()) { + ba.enable(); + } else { + ba.disable(); + } + successful = true; + } catch (SecurityException exception) { + successful = false; } - else { - ba.disable(); - } - successful = true; } // No Bluetooth available else { diff --git a/app/src/main/java/jp/co/cyberagent/stf/query/SetClipboardResponder.java b/app/src/main/java/jp/co/cyberagent/stf/query/SetClipboardResponder.java index 0d5bdc6..465cb72 100644 --- a/app/src/main/java/jp/co/cyberagent/stf/query/SetClipboardResponder.java +++ b/app/src/main/java/jp/co/cyberagent/stf/query/SetClipboardResponder.java @@ -49,13 +49,7 @@ public void cleanup() { } private void setClipboardText(String content) { - if (Build.VERSION.SDK_INT >= 11) { - ((android.content.ClipboardManager) Service.getClipboardManager()) - .setPrimaryClip(ClipData.newPlainText(null, content)); - } - else { - ((android.text.ClipboardManager) Service.getClipboardManager()) - .setText(content); - } + ((android.content.ClipboardManager) Service.getClipboardManager()) + .setPrimaryClip(ClipData.newPlainText(null, content)); } } diff --git a/app/src/main/java/jp/co/cyberagent/stf/query/SetWakeLockResponder.java b/app/src/main/java/jp/co/cyberagent/stf/query/SetWakeLockResponder.java index acd7168..b4a8fb0 100644 --- a/app/src/main/java/jp/co/cyberagent/stf/query/SetWakeLockResponder.java +++ b/app/src/main/java/jp/co/cyberagent/stf/query/SetWakeLockResponder.java @@ -45,7 +45,6 @@ public void cleanup() { releaseWakeLock(); } - @SuppressWarnings("deprecation") private void acquireWakeLock() { releaseWakeLock(); Log.i(TAG, "Acquiring wake lock"); diff --git a/app/src/main/java/jp/co/cyberagent/stf/query/SetWifiEnabledResponder.java b/app/src/main/java/jp/co/cyberagent/stf/query/SetWifiEnabledResponder.java index e572720..f198580 100644 --- a/app/src/main/java/jp/co/cyberagent/stf/query/SetWifiEnabledResponder.java +++ b/app/src/main/java/jp/co/cyberagent/stf/query/SetWifiEnabledResponder.java @@ -18,7 +18,7 @@ public GeneratedMessageLite respond(Wire.Envelope envelope) throws InvalidProtoc Wire.SetWifiEnabledRequest request = Wire.SetWifiEnabledRequest.parseFrom(envelope.getMessage()); - WifiManager wm = (WifiManager)context.getSystemService(Context.WIFI_SERVICE); + WifiManager wm = (WifiManager)context.getApplicationContext().getSystemService(Context.WIFI_SERVICE); wm.setWifiEnabled(request.getEnabled()); diff --git a/build.gradle b/build.gradle index e7ce13a..d1d9e1c 100644 --- a/build.gradle +++ b/build.gradle @@ -1,13 +1,10 @@ -// Top-level build file where you can add configuration options common to all sub-projects/modules. - buildscript { repositories { mavenCentral() google() - jcenter() } dependencies { - classpath 'com.android.tools.build:gradle:4.1.3' + classpath 'com.android.tools.build:gradle:7.0.2' } } @@ -15,7 +12,6 @@ allprojects { repositories { mavenCentral() google() - jcenter() } tasks.withType(JavaCompile) { diff --git a/gradle/wrapper/gradle-wrapper.jar b/gradle/wrapper/gradle-wrapper.jar index e708b1c..7454180 100644 Binary files a/gradle/wrapper/gradle-wrapper.jar and b/gradle/wrapper/gradle-wrapper.jar differ diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index 0ac0cc7..ffed3a2 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,6 +1,5 @@ -#Thu May 20 19:00:41 CEST 2021 distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists +distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip diff --git a/gradlew b/gradlew index 4f906e0..1b6c787 100755 --- a/gradlew +++ b/gradlew @@ -1,7 +1,7 @@ -#!/usr/bin/env sh +#!/bin/sh # -# Copyright 2015 the original author or authors. +# Copyright © 2015-2021 the original authors. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -17,67 +17,101 @@ # ############################################################################## -## -## Gradle start up script for UN*X -## +# +# Gradle start up script for POSIX generated by Gradle. +# +# Important for running: +# +# (1) You need a POSIX-compliant shell to run this script. If your /bin/sh is +# noncompliant, but you have some other compliant shell such as ksh or +# bash, then to run this script, type that shell name before the whole +# command line, like: +# +# ksh Gradle +# +# Busybox and similar reduced shells will NOT work, because this script +# requires all of these POSIX shell features: +# * functions; +# * expansions «$var», «${var}», «${var:-default}», «${var+SET}», +# «${var#prefix}», «${var%suffix}», and «$( cmd )»; +# * compound commands having a testable exit status, especially «case»; +# * various built-in commands including «command», «set», and «ulimit». +# +# Important for patching: +# +# (2) This script targets any POSIX shell, so it avoids extensions provided +# by Bash, Ksh, etc; in particular arrays are avoided. +# +# The "traditional" practice of packing multiple parameters into a +# space-separated string is a well documented source of bugs and security +# problems, so this is (mostly) avoided, by progressively accumulating +# options in "$@", and eventually passing that to Java. +# +# Where the inherited environment variables (DEFAULT_JVM_OPTS, JAVA_OPTS, +# and GRADLE_OPTS) rely on word-splitting, this is performed explicitly; +# see the in-line comments for details. +# +# There are tweaks for specific operating systems such as AIX, CygWin, +# Darwin, MinGW, and NonStop. +# +# (3) This script is generated from the Groovy template +# https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt +# within the Gradle project. +# +# You can find Gradle at https://github.com/gradle/gradle/. +# ############################################################################## # Attempt to set APP_HOME + # Resolve links: $0 may be a link -PRG="$0" -# Need this for relative symlinks. -while [ -h "$PRG" ] ; do - ls=`ls -ld "$PRG"` - link=`expr "$ls" : '.*-> \(.*\)$'` - if expr "$link" : '/.*' > /dev/null; then - PRG="$link" - else - PRG=`dirname "$PRG"`"/$link" - fi +app_path=$0 + +# Need this for daisy-chained symlinks. +while + APP_HOME=${app_path%"${app_path##*/}"} # leaves a trailing /; empty if no leading path + [ -h "$app_path" ] +do + ls=$( ls -ld "$app_path" ) + link=${ls#*' -> '} + case $link in #( + /*) app_path=$link ;; #( + *) app_path=$APP_HOME$link ;; + esac done -SAVED="`pwd`" -cd "`dirname \"$PRG\"`/" >/dev/null -APP_HOME="`pwd -P`" -cd "$SAVED" >/dev/null + +APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit APP_NAME="Gradle" -APP_BASE_NAME=`basename "$0"` +APP_BASE_NAME=${0##*/} # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' # Use the maximum available, or set MAX_FD != -1 to use that value. -MAX_FD="maximum" +MAX_FD=maximum warn () { echo "$*" -} +} >&2 die () { echo echo "$*" echo exit 1 -} +} >&2 # OS specific support (must be 'true' or 'false'). cygwin=false msys=false darwin=false nonstop=false -case "`uname`" in - CYGWIN* ) - cygwin=true - ;; - Darwin* ) - darwin=true - ;; - MINGW* ) - msys=true - ;; - NONSTOP* ) - nonstop=true - ;; +case "$( uname )" in #( + CYGWIN* ) cygwin=true ;; #( + Darwin* ) darwin=true ;; #( + MSYS* | MINGW* ) msys=true ;; #( + NONSTOP* ) nonstop=true ;; esac CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar @@ -87,9 +121,9 @@ CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar if [ -n "$JAVA_HOME" ] ; then if [ -x "$JAVA_HOME/jre/sh/java" ] ; then # IBM's JDK on AIX uses strange locations for the executables - JAVACMD="$JAVA_HOME/jre/sh/java" + JAVACMD=$JAVA_HOME/jre/sh/java else - JAVACMD="$JAVA_HOME/bin/java" + JAVACMD=$JAVA_HOME/bin/java fi if [ ! -x "$JAVACMD" ] ; then die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME @@ -98,7 +132,7 @@ Please set the JAVA_HOME variable in your environment to match the location of your Java installation." fi else - JAVACMD="java" + JAVACMD=java which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. Please set the JAVA_HOME variable in your environment to match the @@ -106,80 +140,95 @@ location of your Java installation." fi # Increase the maximum file descriptors if we can. -if [ "$cygwin" = "false" -a "$darwin" = "false" -a "$nonstop" = "false" ] ; then - MAX_FD_LIMIT=`ulimit -H -n` - if [ $? -eq 0 ] ; then - if [ "$MAX_FD" = "maximum" -o "$MAX_FD" = "max" ] ; then - MAX_FD="$MAX_FD_LIMIT" - fi - ulimit -n $MAX_FD - if [ $? -ne 0 ] ; then - warn "Could not set maximum file descriptor limit: $MAX_FD" - fi - else - warn "Could not query maximum file descriptor limit: $MAX_FD_LIMIT" - fi +if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then + case $MAX_FD in #( + max*) + MAX_FD=$( ulimit -H -n ) || + warn "Could not query maximum file descriptor limit" + esac + case $MAX_FD in #( + '' | soft) :;; #( + *) + ulimit -n "$MAX_FD" || + warn "Could not set maximum file descriptor limit to $MAX_FD" + esac fi -# For Darwin, add options to specify how the application appears in the dock -if $darwin; then - GRADLE_OPTS="$GRADLE_OPTS \"-Xdock:name=$APP_NAME\" \"-Xdock:icon=$APP_HOME/media/gradle.icns\"" -fi +# Collect all arguments for the java command, stacking in reverse order: +# * args from the command line +# * the main class name +# * -classpath +# * -D...appname settings +# * --module-path (only if needed) +# * DEFAULT_JVM_OPTS, JAVA_OPTS, and GRADLE_OPTS environment variables. # For Cygwin or MSYS, switch paths to Windows format before running java -if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then - APP_HOME=`cygpath --path --mixed "$APP_HOME"` - CLASSPATH=`cygpath --path --mixed "$CLASSPATH"` - - JAVACMD=`cygpath --unix "$JAVACMD"` - - # We build the pattern for arguments to be converted via cygpath - ROOTDIRSRAW=`find -L / -maxdepth 1 -mindepth 1 -type d 2>/dev/null` - SEP="" - for dir in $ROOTDIRSRAW ; do - ROOTDIRS="$ROOTDIRS$SEP$dir" - SEP="|" - done - OURCYGPATTERN="(^($ROOTDIRS))" - # Add a user-defined pattern to the cygpath arguments - if [ "$GRADLE_CYGPATTERN" != "" ] ; then - OURCYGPATTERN="$OURCYGPATTERN|($GRADLE_CYGPATTERN)" - fi +if "$cygwin" || "$msys" ; then + APP_HOME=$( cygpath --path --mixed "$APP_HOME" ) + CLASSPATH=$( cygpath --path --mixed "$CLASSPATH" ) + + JAVACMD=$( cygpath --unix "$JAVACMD" ) + # Now convert the arguments - kludge to limit ourselves to /bin/sh - i=0 - for arg in "$@" ; do - CHECK=`echo "$arg"|egrep -c "$OURCYGPATTERN" -` - CHECK2=`echo "$arg"|egrep -c "^-"` ### Determine if an option - - if [ $CHECK -ne 0 ] && [ $CHECK2 -eq 0 ] ; then ### Added a condition - eval `echo args$i`=`cygpath --path --ignore --mixed "$arg"` - else - eval `echo args$i`="\"$arg\"" + for arg do + if + case $arg in #( + -*) false ;; # don't mess with options #( + /?*) t=${arg#/} t=/${t%%/*} # looks like a POSIX filepath + [ -e "$t" ] ;; #( + *) false ;; + esac + then + arg=$( cygpath --path --ignore --mixed "$arg" ) fi - i=`expr $i + 1` + # Roll the args list around exactly as many times as the number of + # args, so each arg winds up back in the position where it started, but + # possibly modified. + # + # NB: a `for` loop captures its iteration list before it begins, so + # changing the positional parameters here affects neither the number of + # iterations, nor the values presented in `arg`. + shift # remove old arg + set -- "$@" "$arg" # push replacement arg done - case $i in - 0) set -- ;; - 1) set -- "$args0" ;; - 2) set -- "$args0" "$args1" ;; - 3) set -- "$args0" "$args1" "$args2" ;; - 4) set -- "$args0" "$args1" "$args2" "$args3" ;; - 5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;; - 6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;; - 7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;; - 8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;; - 9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;; - esac fi -# Escape application args -save () { - for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done - echo " " -} -APP_ARGS=`save "$@"` +# Collect all arguments for the java command; +# * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of +# shell script including quotes and variable substitutions, so put them in +# double quotes to make sure that they get re-expanded; and +# * put everything else in single quotes, so that it's not re-expanded. + +set -- \ + "-Dorg.gradle.appname=$APP_BASE_NAME" \ + -classpath "$CLASSPATH" \ + org.gradle.wrapper.GradleWrapperMain \ + "$@" + +# Use "xargs" to parse quoted args. +# +# With -n1 it outputs one arg per line, with the quotes and backslashes removed. +# +# In Bash we could simply go: +# +# readarray ARGS < <( xargs -n1 <<<"$var" ) && +# set -- "${ARGS[@]}" "$@" +# +# but POSIX shell has neither arrays nor command substitution, so instead we +# post-process each arg (as a line of input to sed) to backslash-escape any +# character that might be a shell metacharacter, then use eval to reverse +# that process (while maintaining the separation between arguments), and wrap +# the whole thing up as a single "set" statement. +# +# This will of course break if any of these variables contains a newline or +# an unmatched quote. +# -# Collect all arguments for the java command, following the shell quoting and substitution rules -eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS" +eval "set -- $( + printf '%s\n' "$DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS" | + xargs -n1 | + sed ' s~[^-[:alnum:]+,./:=@_]~\\&~g; ' | + tr '\n' ' ' + )" '"$@"' exec "$JAVACMD" "$@"