Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TanhLayer.vhdl correct? #7

Open
BlazeCode2 opened this issue Oct 29, 2018 · 1 comment
Open

TanhLayer.vhdl correct? #7

BlazeCode2 opened this issue Oct 29, 2018 · 1 comment

Comments

@BlazeCode2
Copy link
Contributor

Is the TanhLayer.vhdl's logic correct?. it just bit slices the SUM_WIDTH long bit array to BITWIDTH wide. it won't even consider the sign bit. Just take the least significant BITWIDTH bits.
@KamelAbdelouahab
Copy link
Collaborator

Few commits ago I reformulated the tanh layer hdl. This new implementation TanHLayer is kind of trashy
It's supposed to implement a piece-wise approximation of the TanH described here https://hal.archives-ouvertes.fr/hal-01654697/document . If you find time to improve its behavior, please pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KamelAbdelouahab @BlazeCode2