add esmf_logmsg to shr_abort #62
Merged
+28
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fischer-ncar
approved these changes
Jan 24, 2025
ekluzek
reviewed
Jan 24, 2025
|
|
||
| call print_error_to_logs("ERROR", local_string) | ||
|
|
||
| call ESMF_LogWrite(local_string, ESMF_LOGMSG_ERROR, line=line, file=file) |
There was a problem hiding this comment.
@jedwards4b question. What will happen if line and/or file aren't present in the call and they are sent down this way to ESMF_LogWrite? It seems like it might be compiler dependent on how it handles passing down a non-present argument.
But, I'm interested if you did any testing around that. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a call to esmf_logmsg to share abort mod so that both the PET files and component logs are updated with the error message.
Fixes #61