Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMEPS does NOT add files to cpl.input_data_list for existence checking #526

Open
ekluzek opened this issue Jan 18, 2025 · 1 comment · May be fixed by #528
Open

CMEPS does NOT add files to cpl.input_data_list for existence checking #526

ekluzek opened this issue Jan 18, 2025 · 1 comment · May be fixed by #528
Labels
bug Something isn't working

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Jan 18, 2025

CMEPS always has empty cpl.input_data_list files because the buildnml doesn't send the right list of groups to it's write. None of the variables in the groups sent are files and so the list is always empty. The groups sent are: papi_inparm, prof_inparm and debug_inparm. The groups that should be sent are the various *_attributes groups.

See this code difference here, for what I think it should change to:

diff --git a/cime_config/buildnml b/cime_config/buildnml
index 7ffc28f8..d71842ba 100755
--- a/cime_config/buildnml
+++ b/cime_config/buildnml
@@ -320,7 +320,7 @@ def _create_drv_namelists(case, infile, confdir, nmlgen, files):
     # Write namelist file drv_in and initial input dataset list.
     # --------------------------------
     namelist_file = os.path.join(confdir, "drv_in")
-    drv_namelist_groups = ["papi_inparm", "prof_inparm", "debug_inparm"]
+    drv_namelist_groups = ["DRIVER_attributes", "MED_attributes", "ALLCOMP_attributes", "ROF_attributes", "WAV_attributes"]
     nmlgen.write_output_file(
         namelist_file, data_list_path=data_list_path, groups=drv_namelist_groups
     )

Fixing this would be helpful to catch when a CMEPS driver file isn't available on a machine, as well as make it easier to download it.

Technically there are currently no files in the DRIVER_attributes group, but for completeness in case anything is added it seems like it should be in the list. Also more groups could be added that don't currently have files like LND_attributes for example.

@ekluzek ekluzek added the bug Something isn't working label Jan 18, 2025
@ekluzek
Copy link
Collaborator Author

ekluzek commented Jan 18, 2025

I tried this with the above suggested fix for the test:

SMS_D_Ld1.f10_f10_mg37.I2000Clm60Sp.derecho_intel.clm-default

and it properly lists the files:

mesh_mask = /glade/campaign/cesm/cesmdata/inputdata/share/meshes/gx3v7_120309_ESMFmesh.nc
mesh_atm = /glade/campaign/cesm/cesmdata/inputdata/share/meshes/10x15_nomask_c110308_ESMFmesh.nc
mesh_lnd = /glade/campaign/cesm/cesmdata/inputdata/share/meshes/10x15_nomask_c110308_ESMFmesh.nc
mesh_rof = /glade/campaign/cesm/cesmdata/inputdata/share/meshes/r05_nomask_c110308_ESMFmesh.nc

which all exist and check_input_data functions correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant