Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some FATES default filenames to namelist_defaults #2896

Open
ekluzek opened this issue Dec 3, 2024 · 0 comments
Open

Move some FATES default filenames to namelist_defaults #2896

ekluzek opened this issue Dec 3, 2024 · 0 comments
Assignees
Labels
enhancement new capability or improved behavior of existing capability

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Dec 3, 2024

There are some default filenames for FATES that are preserved in the testmod rather than in namelist_defaults. Keeping them in namelist_defaults makes it easier for users to NOT have to know the filenames themselves -- namelist defaults just gives it for you. This makes it easier to run these cases for users and more robust as well, with also removing some of the specific changes needed for the tests themselves.

This was noticed in ctsm5.3.014 as I removed hardcoded checks for existence of these files in build-namelist. By putting them into add_defaults it will already check for existence so there isn't special code needed.

The filenames I see that need this are:

  • flandusepftdat
  • fluh_timeseries

There's also fates_inventory_ctrl_filename, but we currently don't have defaults for it that we test yet.

The conversation that started this is:

       I removed the check for file existence here, because it was too early and caused problems. The check for file existence is a general thing that should be done for all filenames anyway, so doesn't need to have special code to handle it for each one here.

However, this now is still failing to check for file existance at the right time, which causes a build-namelist test to fail. I'm looking into this now...

Originally posted by @ekluzek in #2888 (comment)

The error that's seen in the namelist unit tester is:

1237/3263 < FAIL> <Test Id: 1237> <Desc: inventoryfileDNE>
@ekluzek ekluzek added the enhancement new capability or improved behavior of existing capability label Dec 3, 2024
@ekluzek ekluzek added this to the ctsm6.0.0 (code freeze) milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability
Projects
None yet
Development

No branches or pull requests

2 participants