Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function estimate_flux #43

Open
NPJuncal opened this issue Jan 15, 2024 · 2 comments
Open

function estimate_flux #43

NPJuncal opened this issue Jan 15, 2024 · 2 comments

Comments

@NPJuncal
Copy link
Collaborator

estimate the average organic carbon flux to the soil in a indicated time frame (by default last 100 years) from the organic carbon concentration and ages obtained from a age-depth or age-accumulated mass model

it works but there is at least one bug

tasks:

-check resolution of the cores before estimation. If the user wants to estimate the average flux in the last 100 years but the first sample of the core is already more than 100 years older it can not be done. Check that first sample is younger than the time frame provided to estimate the flux. If it is older add warning: " [[core_id]] resolution is to low to estimate the average oc flux in the last [[time frame provided]] years" or something similar and skip to next core

-write test (some already done)

-ckeck documentation

NPJuncal pushed a commit that referenced this issue Jan 17, 2024
#43
I have a dded a check in function estimate_core_f. It checks if the timeframe to estimate the flux is larger than the age of the first sample. If so, it slips that core and gives a warning.
@NPJuncal
Copy link
Collaborator Author

First task is already done. Remainin tasks:

-write test (some already done)

-ckeck documentation

@NPJuncal
Copy link
Collaborator Author

Change flux to sequestration rate in all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant