Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tokenizing bug #32

Open
ngawangtrinley opened this issue Sep 28, 2020 · 5 comments
Open

tokenizing bug #32

ngawangtrinley opened this issue Sep 28, 2020 · 5 comments

Comments

@ngawangtrinley
Copy link
Collaborator

ngawangtrinley commented Sep 28, 2020 •
edited
Loading

serious bug when writing text.

To replicate add a SEG_TRIGGES char such as comma:

    SEG_TRIGGERS = ['་', '།', '\n', ',']
kehsinhsu pushed a commit that referenced this issue Sep 29, 2020
resolved: tokenizing bug #32
381ac19
@ngawangtrinley
Copy link
Collaborator Author

ngawangtrinley commented Sep 29, 2020 •
edited
Loading

Further bugs:

  • applying level formatting erases last recorded step gh
  • same thing happens with undo/redo
  • cursor jumps to next line when writing on line 3, efd

kehsinhsu pushed a commit that referenced this issue Sep 29, 2020
resolved: tokenizing bug #32
d111353 
(applying level formatting erases last recorded)
kehsinhsu pushed a commit that referenced this issue Oct 1, 2020
#32
2e48a09 
applying level formatting erases last recorded step
cursor jumps
kehsinhsu pushed a commit that referenced this issue Oct 1, 2020
#32
154514f 
applying level formatting erases last recorded step
kehsinhsu pushed a commit that referenced this issue Oct 1, 2020
#32
eae0108 
applying level formatting erases last recorded step
@ngawangtrinley
Copy link
Collaborator Author

the cursor jumps to the wrong places when pressing enter several times. This happens when editing in the middle of a paragraph, after the first char, the cursor jumps to the end of the text.

@ngawangtrinley
Copy link
Collaborator Author

after adding a comma at the end of each line I typed 'b' and the cursor jumps to the end of the paragraph. The second line should be a,bbbb,c,

@ngawangtrinley
Copy link
Collaborator Author

ngawangtrinley commented Oct 3, 2020 •
edited
Loading

Undo should undo 1 syllables at a time, but leave an extra char

received_943747272802743

kehsinhsu pushed a commit that referenced this issue Oct 4, 2020
#32
393bf21 
Using custom token list to make sure token's start and end position.
Resolved cursor jump problems.
@ngawangtrinley
Copy link
Collaborator Author

I just pressed enter several times:

kehsinhsu pushed a commit that referenced this issue Oct 4, 2020
#32
0ce49e8 
resolved pressed enter several times
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ngawangtrinley