Update publish.yml #232
Merged
Update publish.yml #232
+1
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
CLABotify
added a commit
to Expensify/CLA
that referenced
this pull request
Jan 8, 2025
AndrewGable
requested changes
Jan 8, 2025
There was a problem hiding this comment.
I think we can simplify this to match this: https://github.com/Expensify/react-native-onyx/blob/main/.github/workflows/publish.yml
Possibly without the should_run_build: true if it's not needed.
|
Thank you, updated! |
AndrewGable
approved these changes
Jan 8, 2025
|
Seems like it's working again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Updating the workflow as its failing here https://github.com/Expensify/react-native-qrcode-svg/actions/runs/12676094384/workflow
Seems like the correct output variable is
numberhttps://github.com/Expensify/App/blob/8924bc7f64d276804a7ecb1ee8433275456713f6/.github/workflows/sendReassurePerfData.yml#L40What this fixes
Checklist
ExampleAppExampleApp on all platforms:Screenshots/Videos