protobuf support for rpm build for redhat

[sakthishanmugam02]

Describe the bug

• Did you check if this is a duplicate issue?
• Did you test it on the latest FRRouting/frr master branch?

To Reproduce
The document says

http://docs.frrouting.org/projects/dev-guide/en/latest/packaging-redhat.html

**Note**
The only configure option respected when building RPMs is --with-pkg-extra-version.

I guess protobuf support option not compiled by default - so I have to pass additional arguments ?

--enable-protobuf

If I pass also, the rpmbuild would not be honouring this flag? so how to enable protobuf while building RPMs?

@ton31337 Could you please help?

[sakthishanmugam02]

@ton31337 would you be able to guide here?

[ton31337]

Just add --enable-protobuf in frr.spec file on your own.

[sakthishanmugam02]

Thanks @ton31337

Also, I would like to understand another concept of ZAPI - actually I am interested in routes that are learnt by the BGP - and I want to pass on that information to my SDN routes. Should I need to use ZAPI for this purpose or FPM?

If ZAPI, is there any references?

[sakthishanmugam02]

@ton31337 When to use ZAPI and When to use FPM?

[sakthishanmugam02]

@ton31337 also - I added the flag --enable-protobuf and enabled zebra config -M fpm:protobuf but the events are not sent out to FPM program. whereas if I do not use protobuf - then I get route change events to my FPM program

[sakthishanmugam02]

@ton31337 in fact I get error while building rpms. If I set the enable-protobuf option

Checking for unpackaged file(s): /usr/lib/rpm/check-files /root/frr/rpmbuild/BUILDROOT/frr-8.4_dev_MyRPMVersion-01.el8.x86_64
error: Installed (but unpackaged) file(s) found:
   /usr/lib/debug/usr/lib64/libfrr_pb.so.0.0.0-8.4_dev_MyRPMVersion-01.el8.x86_64.debug
   /usr/lib/debug/usr/lib64/libfrrfpm_pb.so.0.0.0-8.4_dev_MyRPMVersion-01.el8.x86_64.debug
   /usr/lib/debug/usr/lib64/libmlag_pb.so.0.0.0-8.4_dev_MyRPMVersion-01.el8.x86_64.debug
   /usr/lib64/libfrr_pb.so.0
   /usr/lib64/libfrr_pb.so.0.0.0
   /usr/lib64/libfrrfpm_pb.so.0
   /usr/lib64/libfrrfpm_pb.so.0.0.0
   /usr/lib64/libmlag_pb.so.0
   /usr/lib64/libmlag_pb.so.0.0.0


RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/lib/debug/usr/lib64/libfrr_pb.so.0.0.0-8.4_dev_MyRPMVersion-01.el8.x86_64.debug
   /usr/lib/debug/usr/lib64/libfrrfpm_pb.so.0.0.0-8.4_dev_MyRPMVersion-01.el8.x86_64.debug
   /usr/lib/debug/usr/lib64/libmlag_pb.so.0.0.0-8.4_dev_MyRPMVersion-01.el8.x86_64.debug
   /usr/lib64/libfrr_pb.so.0
   /usr/lib64/libfrr_pb.so.0.0.0
   /usr/lib64/libfrrfpm_pb.so.0
   /usr/lib64/libfrrfpm_pb.so.0.0.0
   /usr/lib64/libmlag_pb.so.0
   /usr/lib64/libmlag_pb.so.0.0.0

[ton31337]

@ton31337 When to use ZAPI and When to use FPM?

ZAPI is a Zebra API, and for example, other BGP (like GoBGP, etc.) implementations (or any other existing daemons in FRR) can use ZAPI to manipulate route handling.

FPM is an external program that listens for protobuf or Netlink messages.

[sakthishanmugam02]

@ton31337 Thanks. Any hint on build errors I see in RPM build. ?

[sakthishanmugam02]

Ignore - I did not add those files from %buildroot to %files section