Please help see, is this a known code defect?

[liuyuefengcn]

One input parameter of function bgp_show_path_info is 'afi', but when this function calls the function route_vty_out_detail, it directly replaces the 'afi' parameter with a fixed value AFI_IP? Can anyone help see if it's a known code defect or if there's some other particular cause?

Below is the original code for stable9.0:
static void bgp_show_path_info(const struct prefix_rd *pfx_rd,
struct bgp_dest *bgp_node, struct vty *vty,
struct bgp *bgp, afi_t afi, safi_t safi,
json_object *json, enum bgp_path_type pathtype,
int *display, enum rpki_states rpki_target_state)
{
...
route_vty_out_detail(vty, bgp, bgp_node,
bgp_dest_get_prefix(bgp_node), pi,
AFI_IP, safi, rpki_curr_state,
json_paths);
...
}

[ton31337]

Yes, this is a bug, I'll fix it because I can replicate a crash.

[ton31337]

#14464

[liuyuefengcn]

Thanks.