-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JsonParser.getNumberTypeFP()
#1149
Comments
/cc @pjfanning This with #1137 might let us solve the problems: by using combination of |
JsonParser.getNumberTypeExplicit()
JsonParser.getNumberTypeFP()
Initial part for |
One concern: FasterXML/jackson-databind#4410 -- for format backends outside FasterXML there's backwards-compatibility issue. So I'll see if there's a way to improve default handling for |
Currently
JsonParser
has methodgetNumberType()
, with semantics that are loose for many textual formats.Basically formats like JSON do not have similar types as programming languages: so while we have separate
NumberType
entries representingfloat
(32-bit binary FP),double
(64-bit "double"precision binary FP) andBigDecimal
(unlimited-precision, decimal FP), there is no efficient mechanism to actually produce correctNumberType
for floating-point values.Because of this, basically all FP values claim to be of
NumberType.DOUBLE
for such formats.This can be problematic if values are converted first to
double
, then toBigDecimal
, since former cannot accurately represent all decimal numbers.However, binary formats often have specific storage representations that can provide this type information.
The problem comes when converting to Java types: both
java.lang.Number
(or generallyjava.lang.Object
) andJsonNode
.In this case we would ideally use either:
Double
ORBigDecimal
, based on configurationNaN
),Double
as that can represent such values.(further complicating things, we also have secondary means of producing
NaN
values: value overflow fordouble
(and theoretically, but not practically,float
) which can produce+INFINITY
)Given all above confusion, I think we need a new method like
getNumberTypeFP()
-- with matchingenum NumberTypeFP
(to be able to express valueUNKNOWN
, no need for integer types).That will allow deserializers to know if "true number type", and base logic on that, specifically avoiding conversions in case of Binary formats and allowing their use for Textual formats (or in general formats without explicit type information for FP numbers).
EDIT: originally thought we'd need
getNumberTypeExplicit()
, but since the need is specifically for floating-point numbers, let's call itgetNumberTypeFP()
instead; no need for non-FP types. And can indicate semantics are for strict/explicit type.The text was updated successfully, but these errors were encountered: