From 8eebc58b999033e349580a3b0a7ff01e96152d2e Mon Sep 17 00:00:00 2001 From: "Kim, Joo Hyuk" Date: Sun, 12 Jan 2025 15:48:46 +0900 Subject: [PATCH] Clean up remaining chores --- .../jackson/dataformat/protobuf/SerDeserLongTest.java | 3 +++ .../jackson/dataformat/protobuf/WriteErrorsTest.java | 4 ++++ .../failure/JacksonTestFailureExpectedInterceptor.java | 6 ++++++ .../testutil/failure/JacksonTestShouldFailException.java | 1 - 4 files changed, 13 insertions(+), 1 deletion(-) diff --git a/protobuf/src/test/java/com/fasterxml/jackson/dataformat/protobuf/SerDeserLongTest.java b/protobuf/src/test/java/com/fasterxml/jackson/dataformat/protobuf/SerDeserLongTest.java index 5c9d3d682..9d307ff61 100644 --- a/protobuf/src/test/java/com/fasterxml/jackson/dataformat/protobuf/SerDeserLongTest.java +++ b/protobuf/src/test/java/com/fasterxml/jackson/dataformat/protobuf/SerDeserLongTest.java @@ -8,6 +8,9 @@ import com.fasterxml.jackson.dataformat.protobuf.schema.ProtobufSchema; import com.fasterxml.jackson.dataformat.protobuf.schema.ProtobufSchemaLoader; +/** + * Created by miz on 8/10/16. + */ public class SerDeserLongTest { @Test public void testWeirdLongSerDeser() throws IOException { diff --git a/protobuf/src/test/java/com/fasterxml/jackson/dataformat/protobuf/WriteErrorsTest.java b/protobuf/src/test/java/com/fasterxml/jackson/dataformat/protobuf/WriteErrorsTest.java index 515c1a25c..95a9b88a0 100644 --- a/protobuf/src/test/java/com/fasterxml/jackson/dataformat/protobuf/WriteErrorsTest.java +++ b/protobuf/src/test/java/com/fasterxml/jackson/dataformat/protobuf/WriteErrorsTest.java @@ -13,6 +13,10 @@ import static org.junit.jupiter.api.Assertions.assertEquals; +/** + * Unit tests for generation that trigger exceptions (or would + * without suppression). + */ public class WriteErrorsTest extends ProtobufTestBase { static class Point3D extends Point { diff --git a/protobuf/src/test/java/com/fasterxml/jackson/dataformat/protobuf/testutil/failure/JacksonTestFailureExpectedInterceptor.java b/protobuf/src/test/java/com/fasterxml/jackson/dataformat/protobuf/testutil/failure/JacksonTestFailureExpectedInterceptor.java index 3c997b3fe..98c17aad2 100644 --- a/protobuf/src/test/java/com/fasterxml/jackson/dataformat/protobuf/testutil/failure/JacksonTestFailureExpectedInterceptor.java +++ b/protobuf/src/test/java/com/fasterxml/jackson/dataformat/protobuf/testutil/failure/JacksonTestFailureExpectedInterceptor.java @@ -4,6 +4,12 @@ import org.junit.jupiter.api.extension.*; +/** + * Custom {@link InvocationInterceptor} that intercepts test method invocation. + * To pass the test ***only if*** test fails with an exception, and fail the test otherwise. + * + * @since 2.19 + */ public class JacksonTestFailureExpectedInterceptor implements InvocationInterceptor { diff --git a/protobuf/src/test/java/com/fasterxml/jackson/dataformat/protobuf/testutil/failure/JacksonTestShouldFailException.java b/protobuf/src/test/java/com/fasterxml/jackson/dataformat/protobuf/testutil/failure/JacksonTestShouldFailException.java index f135c16b4..369600cca 100644 --- a/protobuf/src/test/java/com/fasterxml/jackson/dataformat/protobuf/testutil/failure/JacksonTestShouldFailException.java +++ b/protobuf/src/test/java/com/fasterxml/jackson/dataformat/protobuf/testutil/failure/JacksonTestShouldFailException.java @@ -7,7 +7,6 @@ * * @since 2.19 */ - public class JacksonTestShouldFailException extends RuntimeException {