Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSTEP-10: Unify testing structure/tools #547

Closed
JooHyukKim opened this issue Jan 11, 2025 · 3 comments · Fixed by #548
Closed

JSTEP-10: Unify testing structure/tools #547

JooHyukKim opened this issue Jan 11, 2025 · 3 comments · Fixed by #548
Labels
Milestone

Comments

@JooHyukKim
Copy link
Member

JooHyukKim commented Jan 11, 2025

This issue serves as an umbrella issue for resolving [JSTEP-10: Unifying testing structure/tools]

TODO

How to do things

Change Code

  • run IntelliJ's "migrate tests 4 -> 5"
  • Check for Junit 3 TestCase and remove the extends part
  • Annotate @Test by : Replace (by text) all public void test to @Test \n public void test
  • Add imports by : Replace public class with import org.jun... Test \n import static Asssertions.*; \n public class

Validate

  • search all public void test... and check Dups or missing(indents)
  • search all public class... and check JavaDoc in between imports
  • search and remove all org.junit.Assert
  • search and remove Assert.*
  • search all assertNotNull error message String usage
@JooHyukKim
Copy link
Member Author

@cowtowncoder Could you open this one up again? I made a mistake above PRs resolve this.

Didn't know "partly resolves #xxx" would also do this 😅

@cowtowncoder cowtowncoder reopened this Jan 12, 2025
@cowtowncoder
Copy link
Member

Yeah, github is being too "smart". :-(

@cowtowncoder
Copy link
Member

Completed, I think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants