Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in admin initializer name #34

Open
clarkwinkelmann opened this issue Jul 31, 2022 · 0 comments
Open

Typo in admin initializer name #34

clarkwinkelmann opened this issue Jul 31, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@clarkwinkelmann
Copy link
Member

The initializer name of the extension in the admin frontend is incorrectly spelled and doesn't match with the extension ID

actual fof-socialprfile
expected fof-socialprofile

app.initializers.add('fof-socialprfile', () => {

This is not causing any issue. But fixing it might, as it would be a breaking change if any other extension relies on the current name.

I suggest we leave it as-it for now, but if there's ever a major update of our extension, try to fix it at the same time.

The initializer in the forum frontend is spelled as expected and doesn't need changing.

@clarkwinkelmann clarkwinkelmann added the enhancement New feature or request label Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant