Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV] 다이어리 상세 페이지 구현 #14

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[DEV] 다이어리 상세 페이지 구현 #14

wants to merge 10 commits into from

Conversation

yugenius0213
Copy link
Collaborator

Summary

다이어리 상세 페이지 구현하였습니다.

Description

  • tailwind.css에 버튼 공통 css를 설정하였습니다.
  • 일기의 id값을 사용해 일기의 내용을 불러오고 삭제를 하였습니다.
스크린샷 2025-01-17 오후 11 57 37

@yugenius0213 yugenius0213 added the dev New feature or request label Jan 17, 2025
@yugenius0213 yugenius0213 self-assigned this Jan 17, 2025
@yugenius0213 yugenius0213 linked an issue Jan 17, 2025 that may be closed by this pull request
일기 상세 페이지 구현 - [손유진] #9
Open
heejung0
heejung0 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@heejung0 heejung0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

벌써 상세 페이지까지 구현하시다니.. 역시 리더님😲
한 파일에 상수로 정리해 놓아서 수정할 때 용이할 것 같네요 수고하셨습니다!

chae1xxlos
chae1xxlos approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@chae1xxlos chae1xxlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

텍스트 상수를 별도로 파일로 분리하여 관리한 점이 너무습니다. 확장성과 유지보수 측면에서 매우 유용합니다.

텍스트 상수를 별도 파일로 분리해서 관리하는것이 좋은 접근이라고 생각합니다! 유지보수 할때도 매우 편리할 것 같네요. 고생 많으셨습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chae1xxlos chae1xxlos chae1xxlos approved these changes

@heejung0 heejung0 heejung0 approved these changes

@gomx3 gomx3 Awaiting requested review from gomx3 gomx3 is a code owner

@katie424 katie424 Awaiting requested review from katie424 katie424 is a code owner

@ye-one222 ye-one222 Awaiting requested review from ye-one222 ye-one222 is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

@yugenius0213 yugenius0213

Labels
dev New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

일기 상세 페이지 구현 - [손유진]
3 participants
@yugenius0213 @heejung0 @chae1xxlos