Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/chart component creation #305

Merged
merged 5 commits into from
Oct 5, 2024

Conversation

charliejlin
Copy link
Collaborator

  1. Show number/percentage functionality not implemented in Chart components (Donut and Progress)
  2. Has charState view that is to be removed at the end of the component
  3. Added the Button Label and Button Link fields to Donut and Progress

Screenshot 2024-10-03 at 12 06 25 AM
^Percentage looks blurry in smaller width for some reason. It fixes itself if I set the zoom to 100%, but idk if that is the issue or if it is a font issue.

@charliejlin charliejlin linked an issue Oct 3, 2024 that may be closed by this pull request
@thanasis457 thanasis457 self-requested a review October 5, 2024 20:24
@thanasis457
Copy link
Contributor

Awesome work. Looks really good

@thanasis457 thanasis457 force-pushed the feature/chartComponentCreation branch from 65b83c9 to 87dd2ec Compare October 5, 2024 21:47
@thanasis457 thanasis457 merged commit 99ac125 into develop Oct 5, 2024
3 checks passed
@thanasis457 thanasis457 deleted the feature/chartComponentCreation branch October 5, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart Component Creation
2 participants