Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gallery view component #307

Merged
merged 8 commits into from
Oct 21, 2024
Merged

Conversation

charliejlin
Copy link
Collaborator

Some comments lol:

  1. Can’t find image for the upload file portion. On Figma, the drop zone is just a screen shot so I free styled it.

  2. Imported existing ‘ImageModel.tsx’ file, but could not call as a component since I needed to modify it. Put modified version in ‘ProviderGallerySlide.tsx’.

  3. Uploading image follows how Map Info uploads images:

    1. User adds file to drop zone
    2. ‘Cancel’ and ‘Save’ button pop up
    3. Image saving should work as I copied the Map Info implementation and that seems to work; modified to update the respective slide’s imgLink property.
    4. Both ‘Cancel’ and ‘Save’ go back to the upload file drop zone. Maybe replace with image from slide’s imgLink property if set? But then how would edit look? Should there be a delete option for the image?
  4. Tried to put gallery creation component into collapsible component but refreshes page every time I click to expand. Maybe something to do with the provider page instead of the collapsible component since the collapsible is dependent on scrollheight and you cannot scroll on page? Removing that style lets you see in collapsible but breaks the expand-close. Also, the collapsible sets side margins for its children component, so child width is slowly gets constrained to middle when viewing from larger screens; not sure if that is how it is supposed to be.

  5. Carousel was not working on add/edit providers screen (refreshes page when trying to go to next slides like clicking the collapsible), moved to ‘SingleProvider.tsx’ and marked with "{/*TO BE DELETED */} as with the gallery creation components in ‘RowForm.tsx’.

@charliejlin charliejlin linked an issue Oct 19, 2024 that may be closed by this pull request
@thanasis457 thanasis457 self-requested a review October 20, 2024 20:20
@thanasis457 thanasis457 removed a link to an issue Oct 20, 2024
@thanasis457 thanasis457 linked an issue Oct 20, 2024 that may be closed by this pull request
@thanasis457 thanasis457 merged commit 0ffb74e into develop Oct 21, 2024
3 checks passed
@thanasis457 thanasis457 deleted the feature/galleryViewComponent branch October 21, 2024 23:00
@thanasis457
Copy link
Contributor

Really good work! As for your comments:

  1. Thanks. What you wrote looks really nice
  2. Not sure if this is a problem. If it works for now then no worries
  3. What you have so far is good. We'll probably alter the style during sprint day
  4. I fixed this. It was a weird bug
  5. Fixed that as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery View Component
2 participants