Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major Bug Fixing #304

Closed
8 tasks done
thanasis457 opened this issue Oct 2, 2024 · 0 comments · Fixed by #309
Closed
8 tasks done

Major Bug Fixing #304

thanasis457 opened this issue Oct 2, 2024 · 0 comments · Fixed by #309
Assignees

Comments

@thanasis457
Copy link
Contributor

thanasis457 commented Oct 2, 2024

Description

Currently there are many small issues with our Filters and Providers System. Try and fix as many of them as possible.

Here is a list of some known issues:

  • Creating a filter should default to Multi-Select (right now it says Description but functions as Multi-Select)
  • Ordering should be reflected on the Map. ie. The first filter should be first on the filters in the Map etc.
  • When deleting a filter we should also remove it from any providers using it.
  • Deleting a provider needs a refresh of the page to reflect that (it should not).
  • When creating a new provider the first two steps of the process, "Map" and "Hours" always show up. The next two, "Tags" and "Text" should appear when there are "multi-select" and "description" filters accordingly. However, right now, the "Tags" and "Text" disappear randomly even when there are filters we can apply to the provider. Find the issue causing this or rewrite the logic from scratch. (I have also noticed that many times the page needs a refresh. This should not be the case. The providers page should adapt to the filters the moment the filters change without needing any refresh.)
  • The tags that you can select when creating a provider are really buggy. Right now some of the filter categories show up, some don't. Fix it and make sure they show up correctly.
  • The autosave functionality for filters is buggy. The first time you you change a letter from the filter title the focus changes to a popup that says the changes got saved. The focus should not change when making changes.
  • When the name of a filter is empty (null) an error throws up which we should fix.

Make any changes to how the filtering system works.

Currently, we have a collection in Firebase named "providers". Inside it we have all the providers but the filters just exist as random key-value pairs inside the provider's object.
If time allows, a more robust system for filters would be to have the following schema:

{
    "providers" : {
        "[Provider's name]" : {
            "filters" : {
                "[description filter]": "Some text",
                "[multi-select filter]": ["Array of strings that match the options selected for this filter"]
            }
        }
    }
}

You might also want to look at the "categories" collection on Firebase. This is where we store all our filters.

@tsun900 tsun900 linked a pull request Oct 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants