Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show counts in autocomplete options #655

Open
fengelniederhammer opened this issue Jan 14, 2025 · 1 comment
Open

Show counts in autocomplete options #655

fengelniederhammer opened this issue Jan 14, 2025 · 1 comment
Labels
components Regarding the components

Comments

@fengelniederhammer
Copy link
Collaborator

Extend gs-lineage-filter , gs-location-filter and gs-text-input such that they show the count of the respective autocomplete options.

This requires #609, #653, #654

@fengelniederhammer fengelniederhammer added the components Regarding the components label Jan 14, 2025
@fengelniederhammer
Copy link
Collaborator Author

fengelniederhammer commented Jan 16, 2025

For the location filter this might actually be difficult:
We get counts for every value tuple that is in LAPIS (suppose (Europe, Germany, Bavaria) has 50 sequences, (Europe, Germany, null) has 20 sequences).

But we don't get counts for every value that we show in the filter (i.e. we don't know how many sequences we have for Europe, because there are no sequences that only have Europe but no other location value set. We also don't know how many sequences we have in Germany, because we only got how many sequences we have in Germany that also have "state = null").

This could maybe be solved by sending an aggregated request to LAPIS for every level in the hierarchy (in the example: also sending a request /aggregated&fields=region to get the counts for the continents and /aggregated?fields=region&fields=country to get the counts for the countries.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components Regarding the components
Projects
None yet
Development

No branches or pull requests

2 participants