You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Especially when working with large datasets, the excessive logging becomes a serious performance hit (see https://stackoverflow.com/a/26754011/6213343), and there is no option to turn it off.
Expected behavior
IMHO logging should only happen on the user side. Instead of relying on geoblaze to log to the console, I think the library should just throw the error so users can decide how to proceed.
Another approach could be to pass a debug option to the geoblaze function that enables logging.
P.S.: I can create a PR if desired!
The text was updated successfully, but these errors were encountered:
First of all: Thanks for this awesome library! 🚀 🔥
Describe the bug
Before throwing an error, geoblaze currently also logs the error to the console using
console.error
(see here for an examplegeoblaze/src/stats/stats.core.js
Line 67 in f99483b
Especially when working with large datasets, the excessive logging becomes a serious performance hit (see https://stackoverflow.com/a/26754011/6213343), and there is no option to turn it off.
To Reproduce
See the following Observable notebook:
https://observablehq.com/@chrispahm/geoblaze-unsupported-geometry-type
When opening the console, a log of the error can be found.
Expected behavior
IMHO logging should only happen on the user side. Instead of relying on geoblaze to log to the console, I think the library should just throw the error so users can decide how to proceed.
Another approach could be to pass a
debug
option to the geoblaze function that enables logging.P.S.: I can create a PR if desired!
The text was updated successfully, but these errors were encountered: