feat: added minConnectionType to the options attribute #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase and make sure lint and tests pass after you add tests to cover the new changes. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I did my best to resolve the conflicts but it needs a proper look from the patch author. The changes look breaking as they are and new tests are missing. @Luccatp If you do not update the PR, we'll have to close it, but you can come back later and create a new one. |
|
I fixed the conflicts and the breaking change but:
|
|
I will try to fix in this week time. The effectiveType uses only this values: https://developer.mozilla.org/en-US/docs/Web/API/NetworkInformation/effectiveType#value Thank you for your collaboration and interest in my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a new options that gives developer the power of choosing which type of connection should be the minimum to prefetch or prerender the link, instead of always it being 3g.
Fixes #283