Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use torch inference container #1617

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

inardini
Copy link
Contributor

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • You are listed as the author in your notebook or README file.
    • Your account is listed in CODEOWNERS for the file(s).
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
  • Ensure the tests and linter pass (Run nox -s format from the repository root to format).
  • Appropriate docs were updated (if necessary)

@inardini inardini requested a review from a team as a code owner January 10, 2025 13:26
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide a full review shortly. In the meantime, here's a quick summary to help everyone get up to speed:

This pull request, "fix: use torch inference container", aims to fix an issue by switching to using a PyTorch inference container. Unfortunately, without the actual patch content, I can't provide specifics on which files were changed or the exact nature of the fix. I'll update this summary once I've reviewed the diff.

Summary of Intent (Based on Limited Information):

  • The primary goal is to improve the inference process by leveraging a PyTorch inference container.
  • This likely involves changes to how the model is loaded and executed.

Summary of Changes (To be updated after patch review):

  • Files modified: (To be determined after reviewing the patch)
  • Specific changes: (To be determined after reviewing the patch)

I'll provide a more detailed summary including specific file changes and code snippets once I've reviewed the complete patch. Apologies for the incomplete information at this stage.


And now, a little haiku to lighten the mood:

Code flows like a stream,
Fixes merge, a gentle hum,
Progress finds its way.

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request title and description are well-formatted and informative. The checklist ensures all necessary steps are taken before merging. However, without code changes in the patches, I can't provide specific feedback. Please provide the diff so I can review effectively.

@holtskinner holtskinner merged commit 4ca4987 into GoogleCloudPlatform:main Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants