Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting-started/sessions: github.com/GoogleCloudPlatform/firestore-gorilla-sessions is no longer maintained #4280

Open
gecko655 opened this issue Jul 19, 2024 · 2 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@gecko655
Copy link

gecko655 commented Jul 19, 2024

In which file did you encounter the issue?

github.com/GoogleCloudPlatform/firestore-gorilla-sessions v0.1.0

Did you change the file? If so, how?

N/A

Describe the issue

The repository https://github.com/GoogleCloudPlatform/firestore-gorilla-sessions has been archived since 2022 and the last commit to the repository was 5 years ago.

It seems to be inappropriate to choose to use the firestore-gorilla-sessions library at this moment and the getting-stared/sessions example should be updated to the modern implementation, at least the example should not use firestore-gorilla-sessions.

The example is also displayed at the official document: https://cloud.google.com/go/getting-started/session-handling-with-firestore

@gecko655 gecko655 added priority: p2 Moderately-important priority. Fix may not be included in next release. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 19, 2024
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 19, 2024
@subfuzion
Copy link
Contributor

Hi @gecko655 I noticed this comment about Gorilla Sessions being in flux until the Go v1.23 release. I also noticed under store implementations that they're still linking to firestore-gorilla-sessions.

Assuming holding off until gorilla/sessions stabilizes for the 1.23 release, are you suggesting using any particular store backend as a replacement, or are you suggesting using something altogether different from gorilla/sessions?

@gecko655
Copy link
Author

gecko655 commented Aug 7, 2024

My understanding is that gorilla/sessions will continue developing, but GoogleCloudPlatform/firestore-gorilla-sessions seemed to have stopped being maintained.

There is still a link to GoogleCloudPlatform/firestore-gorilla-sessions in the README of the gorilla/sessions repository. However, this does not seem to imply that GoogleCloudPlatform/firestore-gorilla-sessions maintenance will continue in the future. It merely list the community maintained implementations that exist.

Since this repository itself belongs to the GoogleCloudPlatform organization, I believe the possible alternatives are one of the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants