Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESPN Api link broken - Failing integration tests #30

Open
austinegri opened this issue Apr 7, 2023 · 4 comments
Open

ESPN Api link broken - Failing integration tests #30

austinegri opened this issue Apr 7, 2023 · 4 comments
Assignees
Labels

Comments

@austinegri
Copy link

austinegri commented Apr 7, 2023

References

Integration tests are failing as the ESPN api link no longer returns game data:

Tested with current 2023 gameId and found link was broken for this as well so ESPN must've changed the url.

Screenshot 2023-04-07 at 13-10-36 ESPN - Serving Sports Fans  Anytime  Anywhere

Acceptance Criteria

  • Proper link found and replaced to fetch ESPN game data
@austinegri
Copy link
Author

Perhaps ESPN playbyplay tab could be the answer here
i.e. https://www.espn.com/nhl/playbyplay/_/gameId/401459832

@HarryShomer
Copy link
Owner

Hey @austinegri!

Thanks for pointing this out. I actually noted this in one of my last commits (see b59c458). I don't think this should be a problem for most recent seasons as I believe the NHL has done a better job of recording the coordinates in the API game feed.

I'm currently very busy with work so I won't have a chance to take a closer look until the summer.

Regards,
Harry

@austinegri
Copy link
Author

Thanks for the reply @HarryShomer!

My bad I didn't see the recent commit. No worries I understand work is priority, this is a side project and figured it would be good to have a tracking issue.

Do you know around which season would start to have most of the data?

@HarryShomer
Copy link
Owner

Do you know around which season would start to have most of the data?

Tbh I'm not sure. The NHL has been known to go back and fix old games.

Your best bet is to just try different seasons and see what happens.

@HarryShomer HarryShomer self-assigned this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants