From cdaab36096179ba459ed27597e7f1c67705836b5 Mon Sep 17 00:00:00 2001
From: Simon Krajewski <simon@haxe.org>
Date: Mon, 16 Dec 2024 11:59:05 +0100
Subject: [PATCH] fix php too

---
 std/php/_std/haxe/xml/Parser.hx | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/std/php/_std/haxe/xml/Parser.hx b/std/php/_std/haxe/xml/Parser.hx
index 216a96ec81f..ed0fa238bfc 100644
--- a/std/php/_std/haxe/xml/Parser.hx
+++ b/std/php/_std/haxe/xml/Parser.hx
@@ -175,9 +175,8 @@ class Parser {
 								p += 8;
 								state = S.DOCTYPE;
 								start = p + 1;
-							} else if (str.fastCodeAt(p + 1) != '-'.code || str.fastCodeAt(p + 2) != '-'.code)
-								throw new XmlParserException("Expected <!--", str, p);
-							else {
+							} else if (str.fastCodeAt(p + 1) != '-'.code || str.fastCodeAt(p + 2) != '-'.code) throw new XmlParserException("Expected <!--",
+								str, p); else {
 								p += 2;
 								state = S.COMMENT;
 								start = p + 1;
@@ -362,8 +361,10 @@ class Parser {
 			if (parent.nodeType == Element) {
 				throw new XmlParserException("Unclosed node <" + parent.nodeName + ">", str, p);
 			}
-			if (p != start || nsubs == 0) {
+			if (p != start)
 				buf = buf.addSub(str, start, p - start);
+			var str = buf.toString();
+			if (str.length > 0 || nsubs == 0) {
 				addChild(Xml.createPCData(buf));
 			}
 			return p;