Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI v0.5.0 sdist is missing test data #114

Open
jayvdb opened this issue Mar 1, 2021 · 3 comments
Open

PyPI v0.5.0 sdist is missing test data #114

jayvdb opened this issue Mar 1, 2021 · 3 comments
Milestone

Comments

@jayvdb
Copy link

jayvdb commented Mar 1, 2021

pdftotree-0.5.0/tests> ls
__init__.py  test_basic.py  test_table_detection.py

As a reult, running the tests from the PyPI sdist isnt currently possible.

The usual/old solution is to create a MANIFEST.in , which can be generated using check-manifest , but there are newer ways and tools if you do not want another metadata file in the repo.

@lukehsiao
Copy link
Contributor

I see your point. One concern I would have is that the test data can be quite large. I'm not sure we actually want to bundle that together. Is there a good best practice to follow here?

@jayvdb
Copy link
Author

jayvdb commented Mar 19, 2021

Best practise is to distribute wheels which only include the minimum needed to use the package, and a sdist which is a version snaphot of the 'source' which includes whatever is considered useful, e.g. docs, tests, test data, etc.

@lukehsiao
Copy link
Contributor

Ah, I see. That makes sense then.

Would you happen to have the time to put together a PR for this? If not, it may be some time before I can get around to looking into this. I'll need to read up on the trade-offs of MANIFEST.in compared to what the more recent methods are.

@lukehsiao lukehsiao added this to the v0.5.1 milestone Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants