Spoke export no shadows anymore

[ArneKossmann]

Hey,
actually I'm working on a custom client project on AWS(installed on July2020), without any problems so far.
But since a few days our designer can not export shadows via spoke anymore.
In old scenes the shadows are still visible until we re-published them.

Edit:
I've also undeployed our custom client to check if there's any problem. But we got the same results.
Should we update our spoke on AWS somehow?

Thanks in advance,
Arne.

[cvanmeurs]

Sorry, this issue seems to have slipped through the cracks - looks like it's been a while since you posted this. Have you resolved the issue since then? If you're still having trouble, I'd be happy to take a look at your scene for you and see if I can figure out what's going on.

[ArneKossmann]

Hey!
Unfortunately I was not really able to fix this issue. But I did some more tests and the shadow-problem only appears with the directional-light.
Here's a test-scene in Spoke...

...as you can see. I placed the light a little bit off center.
And here is the scene in hubs...

...the shadow is cropped off. It looks like the shadow camera frustum is too small.
https://threejs.org/docs/index.html#api/en/cameras/OrthographicCamera
So I've found this function "resizeShadowCameraFrustum" in both sources.
https://github.com/mozilla/Spoke/blob/master/src/editor/utils/resizeShadowCameraFrustum.js
https://github.com/mozilla/hubs/blob/master/src/systems/shadow-system.js
But I cound't figure out why it works in Spoke and not in Hubs.
At the moment I use the light scaling instead as a workaround.

Oh and here's the link to the remixable test-scene...
https://hubs.mozilla.com/scenes/WYb5Eqy/shadow-test
https://hubs.mozilla.com/KZ6eMtD/shadow-test/
(I'm not sure how to share scenes :/ )

Thanks for your help!

[cvanmeurs]

@robertlong Hey Robert, do you know what could be going on here? It's a simple setup and I'm able to reproduce it - shadows look correct in Spoke but are not in Hubs...

[j-conrad]

I also reproduced it using the same light transform settings in the screenshot. I seem to recall some change that occurred to shadow frustum stuff a while back, but I forget exactly.

[cvanmeurs]

Well this is strange - I added a second object to the scene and suddenly both have correct shadows in Hubs.

[cvanmeurs]

Yeah, duplicate that floating floor piece and move it over and publish again - works.

[cvanmeurs]

Mine works. But I didn't move it straight up...

[cvanmeurs]

[j-conrad]

Looks like the duplicate was a red herring of sorts... I can get the shadow to draw correctly if I move a single floor piece away from the origin.

[cvanmeurs]

Yeah you're right; if you move it straight up it's still borked. WEIRD

[cvanmeurs]

I get the same results if I move the 2 stacked pieces laterally away from the origin - no shadows at all, in fact. Not even cast onto the lower floating platform.