From 5419cd1b8cb34f8e8cee075ee6b21981cd2a515b Mon Sep 17 00:00:00 2001 From: Revital Sur Date: Tue, 15 Oct 2024 10:39:24 +0300 Subject: [PATCH] Address review comments. Signed-off-by: Revital Sur --- transforms/add_new_kfp_workflow.md | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/transforms/add_new_kfp_workflow.md b/transforms/add_new_kfp_workflow.md index 3e095f1d7..54ba0dc0b 100644 --- a/transforms/add_new_kfp_workflow.md +++ b/transforms/add_new_kfp_workflow.md @@ -2,13 +2,12 @@ This README outlines the steps to add a new KFP workflow for a new transform under [transforms](./transforms/) directory. -1) Create the workflow. [pipeline generator](../kfp/pipeline_generator/single-pipeline/) can be used for that. +1) Create a new `kfp_ray` directory in the transform directory, similar to [this directory](universal/noop/kfp_ray/). -2) Create a new `kfp_ray` directory in the transform directory, similar to [this directory](universal/noop/kfp_ray/). Inside this directory, include the following: - - The workflow file created in the previous step. - - `pipeline_definitions.yaml`, if the workflow was generated using the [pipeline generator](../kfp//pipeline_generator/single-pipeline/). - - `Makefile` file similar to [this Makefile example](./universal/noop/kfp_ray/Makefile). +2) Create the workflow and add it to `kfp_ray` directory. It is recommended to use the [pipeline generator](../kfp/pipeline_generator/single-pipeline/) for that. If the workflow was generated using the [pipeline generator](../kfp//pipeline_generator/single-pipeline/) also include `pipeline_definitions.yaml` file used to generate the workflow in the `kfp_ray` directory. + +3) Add `Makefile` file to `kfp_ray` directory similar to [this Makefile example](./universal/noop/kfp_ray/Makefile). 3) Add the path to the transform input directory in the [populate_minio script](../scripts/k8s-setup/populate_minio.sh). This path is used when testing the workflow. 4) Create a GitHub Action for the kfp workflow using the `make` command in the [.github/workflows/](../.github/workflows/README.md) directory. -5) Update the workflows list in [README.md](../kfp/README.md) file. \ No newline at end of file +5) Update the workflows list in [README.md](../kfp/README.md) file.