Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodDisruptionBudget not updated when RedisCluster update #104

Open
takumakume opened this issue Mar 30, 2023 · 5 comments · May be fixed by #105
Open

PodDisruptionBudget not updated when RedisCluster update #104

takumakume opened this issue Mar 30, 2023 · 5 comments · May be fixed by #105

Comments

@takumakume
Copy link

Problems

I am using v0.3.14 and found a problem that MinAvailable of PodDisruptionBudget is not updated when NumberOfPrimaries and ReplicationFactor of RedisCluster are updated.

Proposal

Add processing to recalculate and update MinAvailable of PodDisruptionBudget in reconcil of RedisCluster.

@cin
Copy link
Contributor

cin commented Mar 30, 2023

Thanks for the PR @takumakume! Sorry for the delay. I'll take a look at the PR ASAP (will probably be a couple of days though).

@takumakume
Copy link
Author

I understand if you're busy, but could we confirm? @cin

@cin
Copy link
Contributor

cin commented Apr 24, 2023

Sorry @takumakume. Unfortunately, I don't think anyone actively maintains this project anymore at IBM. I've been slowly working on migrating this over to a fork -- here. Hopefully I'll get some time to work on it this week. It would be cool to get someone to periodically merge things into this repo though.

@takumakume
Copy link
Author

I see. Does this mean that the Pull Request for this Issue is not going to be merged?

My team uses IBM/operator-for-redis-cluster in multiple production environments. (Thank you for everything)

It is an important element and I will continue to be proactive in maintaining operator-for-redis-cluster.

Now that I understand the situation, I too will fork temporarily. At least until the @cin repository becomes active.

@gautamabhishek46
Copy link

Hy @takumakume were you able to test your change and use it in production ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants