Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infinite loop in network construction when downstream id of an outlet is >= 0 #108

Open
thurber opened this issue Feb 9, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@thurber
Copy link
Contributor

thurber commented Feb 9, 2024

If an outlet grid cell has a nonnegative downstream id that doesn't exist, a user may expect it to be treated as an outlet; instead they get stuck in an infinite loop due to the interactions between:

Fix should be any negative j breaking the while loop, but should consider also setting the i to an outlet in that case -- may be other subtle issues.

@thurber thurber self-assigned this Feb 9, 2024
@thurber thurber added the bug Something isn't working label Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant