Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPU functionality in NamedDimsArray #1286

Closed
wants to merge 132 commits into from
Closed

GPU functionality in NamedDimsArray #1286

wants to merge 132 commits into from

Conversation

kmp5VT
Copy link
Collaborator

@kmp5VT kmp5VT commented Dec 14, 2023

Description

@mtfishman This is branch to see if its possible to use different array backends in the NamedDimsArray object.

Checklist:

  • Add device loop to tests
  • If things break create minimal changes to allow code to work with different backends
  • Tests should run with allowscalar = false

kmp5VT and others added 30 commits October 18, 2023 14:18
@kmp5VT
Add FieldType module with Unallocated and Unspecified Types
7453e04
@kmp5VT
format
af065e7
@kmp5VT
Merge branch 'main' into kmp5/feature/FieldTypes
bd2a078
@mtfishman
Merge branch 'main' into kmp5/feature/FieldTypes
5fa5fab
@kmp5VT
Split up fieldtypes into Unallocated and Unspecified modules
86872e1
@kmp5VT
More UnallocatedFill implementation.
071ae92
@kmp5VT
Start simplifying the UnallocatedZeros file
1a849c9
@kmp5VT
Fix typo
297aaa2
@kmp5VT
format
3fc526c
@kmp5VT
Update to the Unallocatedfill/zero code
c9fb989
@kmp5VT
format
e0e3652
@kmp5VT
Merge branch 'main' into kmp5/feature/FieldTypes
7e58e30
@kmp5VT
Updates to code. Still working on all of these
ae13d96
@kmp5VT
Add some promote rules. Still working here
3839f88
@kmp5VT
format
c1b834f
@kmp5VT
Merge commit '66f5d391a6ef01834658ec9d5a9a8ba3d4b0f827' into kmp5/fea…
e9d8b06 
…ture/FieldTypes
@kmp5VT
Merge branch 'main' into kmp5/feature/FieldTypes
83bbd37
@kmp5VT
Start working on Unallocated settype functions
e2c59cb
@kmp5VT
format
145882e
@kmp5VT
Merge branch 'main' into kmp5/feature/FieldTypes
8438d5d
@kmp5VT
Fix set_types
b5ac4ce
@kmp5VT
formatting
c136685
@kmp5VT
format
4d1b976
@kmp5VT
Update UnallocatedArrays
4e265ce
@kmp5VT
format
2b2a6b2
@kmp5VT
Merge branch 'main' into kmp5/feature/FieldTypes
794d6ba
@kmp5VT
CuArray name change, fix warning
305c47b
@kmp5VT
Some fixes
1468c69
@kmp5VT
Add comment
a25ec05
@kmp5VT
I don't need getindex function and [I...] still works
a824fab
kmp5VT added 25 commits December 8, 2023 15:59
@kmp5VT
format
5e3601e
@kmp5VT
Merge branch 'main' into kmp5/feature/FieldTypes
3ce2ce8
@kmp5VT
Add more tests for UnallocatedFill
4246757
@kmp5VT
Move tests to braodcast
417e025
@kmp5VT
Add more tests
4e70bb3
@kmp5VT
Create a trival convert foreach UnallocatedArray
52e21b0
@kmp5VT
Remove promote_rules
d874b1b
@kmp5VT
Move using to each file
611420b
@kmp5VT
Create an unallocatedArray typedef
6011fbc
@kmp5VT
Remove comment
bcf89f1
@kmp5VT
Definitions to fix UnallocatedZeros addition
a6b9ec7
@kmp5VT
Some additional fixes
03655d0
@kmp5VT
Remove tensor tests
e9ed6c5
@kmp5VT
Test similar
0c03fab
@kmp5VT
Remove NDTensor variables
2a04e0a
@kmp5VT
Remove comment
24f185c
@kmp5VT
Add comment
b64372d
@kmp5VT
format
afebe2a
@kmp5VT
Update constructors and fix + for UnallocatedFill
5bd1fd3
@kmp5VT
Make only one constructor for now that requires an abstractarray type
a41a70c
@kmp5VT
Assue alloc defines constructor for type
4bd3028
@kmp5VT
Remove comment
cd42628
@kmp5VT
remove comment
16daf49
@kmp5VT
format
2693dfc
@kmp5VT
Start testing NamedDimsArray to see if its GPU compatable.
2d97f18
@kmp5VT kmp5VT requested a review from mtfishman December 14, 2023 22:00
@kmp5VT kmp5VT marked this pull request as draft December 14, 2023 22:01
@kmp5VT
Copy link
Collaborator Author

kmp5VT commented Dec 14, 2023

@mtfishman I realize now this is a relatively confusing PR because I built it off of the UnallocatedArrays branch. I am closing this and will move it to a new branch from Main

@kmp5VT kmp5VT closed this Dec 14, 2023
@kmp5VT kmp5VT deleted the kmp5/feature/generic_testing branch April 15, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtfishman mtfishman Awaiting requested review from mtfishman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmp5VT @eval @mtfishman