-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding documentation #138
base: main
Are you sure you want to change the base?
Adding documentation #138
Conversation
# Conflicts: # src/main/java/team/rocket/Enums/Direction.java # src/main/java/team/rocket/IO/UI.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If something was a javadoc before don't just convert it to a comment. Also this appears to be a bunch of formatting changes rather then adding documentation.
*/ | ||
public enum Direction { | ||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No point in getting rid of these javadocs, they're necessary for the API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with mention towards the Direction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is half of this just adding spaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this change was necessary.
*/ | ||
public class TerminalFlagRequest { | ||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were intentionally made to be javadocs.
Added and edited documentation and edited coding style