Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stay logged in forever #29

Open
bburdette opened this issue Dec 12, 2022 · 3 comments
Open

stay logged in forever #29

bburdette opened this issue Dec 12, 2022 · 3 comments

Comments

@bburdette
Copy link
Contributor

timeclonk logs us out pretty regularly. I had increased the token timeout, but its still not fixed.

thinking about making a new token every site visit, replacing the old one, and never requiring login after the first time. better than a permanent token. anyway needs fixing.

@bburdette
Copy link
Contributor Author

solved by pr #36

@bburdette
Copy link
Contributor Author

Or not!

@bburdette bburdette reopened this Feb 13, 2023
@bburdette
Copy link
Contributor Author

In the current scheme a new token is created on page load, and the previous token is expired. But the problem is sometimes the new token doesn't get set in the browser, and the previous token keeps being used. The result is a new login being required.

Tentative solution is to create a new token on page load, and link it to the previous token. When the new token actually gets used by the browser (ie api call), then the previous token will be removed. I'll experiment with this on zknotes before trying it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant