Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

Refactor EmulGlue #5

Open
RuthgerD opened this issue Nov 15, 2020 · 0 comments
Open

Refactor EmulGlue #5

RuthgerD opened this issue Nov 15, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@RuthgerD
Copy link
Collaborator

Like TorchUI #4 EmulGlue isn't as good as it can be.

Goals

  • Design a better internal api to start / stop / compile sketches, communicate errors and such with the primary user being the UI
  • Handle resets better, EmulGlue::reset_sketch is just bad and untested and its unknown if we properly join the 2 threads we store (m_ino_runtime and m_compile_tr); aside from threads its also unknown if we properly delete the car from the world
  • Handle various config files better, its a bit stupid how EmulGlue has to deserialize configs from a file path, ideally completely push this responsibility to the caller.
  • More.. I need to do more in dept research as EmulGlue is a bit more tricky than TorchMenu

This issue will evolve over time as I add more things / concrete issues / solutions

@RuthgerD RuthgerD self-assigned this Nov 15, 2020
@RuthgerD RuthgerD added the enhancement New feature or request label Nov 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant