Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new scoring criterion for ocean carbon uptake #79

Open
4 of 5 tasks
melatg0 opened this issue Mar 21, 2024 · 1 comment
Open
4 of 5 tasks

Adding new scoring criterion for ocean carbon uptake #79

melatg0 opened this issue Mar 21, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@melatg0
Copy link

melatg0 commented Mar 21, 2024

Adding package data for observed ocean carbon uptake to use for constructing a new scoring criterion within the Matilda package.

  • Locate ocean carbon uptake data
  • Format ocean carbon uptake data
  • Add data to Matilda's internal data system/file structure
  • Build new ocean carbon uptake scoring criterion
  • Test scoring criterion via Matilda runs
@jk-brown jk-brown added the enhancement New feature or request label Mar 21, 2024
@jk-brown
Copy link
Collaborator

jk-brown commented Mar 26, 2024

So far this looks pretty good.
Some things we will want in order to improve package architecture:

  1. using base syntax to format the ocean carbon uptake data - currently using tidyr, but ideally we don't want to include this as a package dependency.
  • edit ocean format code to use base R
  1. Nice job adding the data to the internal data system. would love to see if it pops up as available on your forked package. I think we want to improve this system structure. This is something that I should have done a long time ago!

@melatg0 for week of 3/26-4/2:

  • organize data modification and importing with usedata():
  • Top Level of package
    • data-raw
      • modify_data.R - this will be the script where we modify all observed data the package uses in one place.
      • load_data.R - this is where we will load all the modified data to the package (usethis::use_data()).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants