diff --git a/CryptoExchange.Net.UnitTests/TestImplementations/TestBaseClient.cs b/CryptoExchange.Net.UnitTests/TestImplementations/TestBaseClient.cs index b1bdb340..bc53c577 100644 --- a/CryptoExchange.Net.UnitTests/TestImplementations/TestBaseClient.cs +++ b/CryptoExchange.Net.UnitTests/TestImplementations/TestBaseClient.cs @@ -60,11 +60,6 @@ public override void AuthenticateRequest(RestApiClient apiClient, Uri uri, HttpM headers = new Dictionary(); } - public override string Sign(string toSign) - { - return toSign; - } - public string GetKey() => _credentials.Key.GetString(); public string GetSecret() => _credentials.Secret.GetString(); } diff --git a/CryptoExchange.Net/Clients/BaseClient.cs b/CryptoExchange.Net/Clients/BaseClient.cs index 6e1ac96f..2a7a5898 100644 --- a/CryptoExchange.Net/Clients/BaseClient.cs +++ b/CryptoExchange.Net/Clients/BaseClient.cs @@ -52,7 +52,7 @@ protected BaseClient(ILoggerFactory? logger, string name) /// /// /// - public virtual void Initialize(ExchangeOptions options) + protected virtual void Initialize(ExchangeOptions options) { if (options == null) throw new ArgumentNullException(nameof(options)); diff --git a/CryptoExchange.Net/Clients/SocketApiClient.cs b/CryptoExchange.Net/Clients/SocketApiClient.cs index a0f43a1c..db94163e 100644 --- a/CryptoExchange.Net/Clients/SocketApiClient.cs +++ b/CryptoExchange.Net/Clients/SocketApiClient.cs @@ -563,7 +563,7 @@ protected void AddGenericHandler(string identifier, Action action) /// /// /// - public virtual Task GetReconnectUriAsync(SocketConnection connection) + protected internal virtual Task GetReconnectUriAsync(SocketConnection connection) { return Task.FromResult(connection.ConnectionUri); } @@ -573,7 +573,7 @@ protected void AddGenericHandler(string identifier, Action action) /// /// The original request /// - public virtual Task> RevitalizeRequestAsync(object request) + protected internal virtual Task> RevitalizeRequestAsync(object request) { return Task.FromResult(new CallResult(request)); } @@ -683,7 +683,7 @@ protected virtual IWebsocket CreateSocket(string address) /// Identifier for the periodic send /// How often /// Method returning the object to send - public virtual void SendPeriodic(string identifier, TimeSpan interval, Func objGetter) + protected virtual void SendPeriodic(string identifier, TimeSpan interval, Func objGetter) { if (objGetter == null) throw new ArgumentNullException(nameof(objGetter)); diff --git a/CryptoExchange.Net/Interfaces/IRestApiClient.cs b/CryptoExchange.Net/Interfaces/IRestApiClient.cs index e6a63e12..b82b494b 100644 --- a/CryptoExchange.Net/Interfaces/IRestApiClient.cs +++ b/CryptoExchange.Net/Interfaces/IRestApiClient.cs @@ -17,17 +17,5 @@ public interface IRestApiClient : IBaseApiClient /// Total amount of requests made with this API client /// int TotalRequestsMade { get; set; } - - /// - /// Get time offset for an API client. Return null if time syncing shouldnt/cant be done - /// - /// - TimeSpan? GetTimeOffset(); - - /// - /// Get time sync info for an API client. Return null if time syncing shouldnt/cant be done - /// - /// - TimeSyncInfo? GetTimeSyncInfo(); } } \ No newline at end of file diff --git a/CryptoExchange.Net/Interfaces/ISocketApiClient.cs b/CryptoExchange.Net/Interfaces/ISocketApiClient.cs index b7cfce15..7d1c3c6b 100644 --- a/CryptoExchange.Net/Interfaces/ISocketApiClient.cs +++ b/CryptoExchange.Net/Interfaces/ISocketApiClient.cs @@ -27,14 +27,6 @@ public interface ISocketApiClient: IBaseApiClient /// The factory for creating sockets. Used for unit testing /// IWebsocketFactory SocketFactory { get; set; } - - /// - /// Get the url to reconnect to after losing a connection - /// - /// - /// - Task GetReconnectUriAsync(SocketConnection connection); - /// /// Log the current state of connections and subscriptions /// @@ -45,19 +37,6 @@ public interface ISocketApiClient: IBaseApiClient /// Task ReconnectAsync(); /// - /// Update the original request to send when the connection is restored after disconnecting. Can be used to update an authentication token for example. - /// - /// The original request - /// - Task> RevitalizeRequestAsync(object request); - /// - /// Periodically sends data over a socket connection - /// - /// Identifier for the periodic send - /// How often - /// Method returning the object to send - void SendPeriodic(string identifier, TimeSpan interval, Func objGetter); - /// /// Unsubscribe all subscriptions /// ///