tumbler.py, ValueError

[mrdeathly]

Hi,
I tried to tumble my bitcoins two times now. After a while I always get this error:

File "tumbler.py", line 576, in main
irc.run()
File "/home/--/Desktop/joinmarket-master/joinmarket/irc.py", line 639, in run
self.__handle_line(line)
File "/home/--/Desktop/joinmarket-master/joinmarket/irc.py", line 522, in __handle_line
self.__handle_privmsg(_chunks[0], _chunks[2], get_irc_text(line))
File "/home/--/Desktop/joinmarket-master/joinmarket/irc.py", line 473, in __handle_privmsg
self.__on_privmsg(nick, parsed)
File "/home/--/Desktop/joinmarket-master/joinmarket/irc.py", line 340, in __on_privmsg
self.on_sig(nick, sig)
File "/home/--/Desktop/joinmarket-master/joinmarket/taker.py", line 549, in on_sig
self.cjtx.add_signature(nick, sig)
File "/home/--/Desktop/joinmarket-master/joinmarket/taker.py", line 242, in add_signature
self.utxos[nick].remove(u[1])
ValueError: list.remove(x): x not in list

done

What am I doing wrong?

[chris-belcher]

Thanks for this crash report.

I think the relevant line is here https://github.com/JoinMarket-Org/joinmarket/blob/master/joinmarket/taker.py#L242

My first guess is the maker sent the same signature twice. However we can't know for sure because we can't see the debug log. I think #403 is useful so users can upload their logs without worrying about their privacy.

Reading that line above, it does seem quite clear that if the maker sent the same signature twice it would crash the taker. Maybe it's worth fixing that even if we haven't seen the debug log?

[mrdeathly]

I'd be willing to try it again, censor my debug log with some python script manually (if that is even possible, i don't know) and post it here, if the same error occurs again. But before that I have a question about the cj/tx fees.
During the second attempt of tumbling I had to raise the maximum cjfee to 20000 because the default values were to low. The bitcoins I initially sent to my joinmarket-wallet and the bitcoins I have now on my jm-wallet and receiving wallet differ by a amount of ~0.034 btc. Does this amount of paid fees make sense or did I lose some btc because of something different/understand the -x flag of tumbler.py wrong?