We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When an empty sequence is created, it adds an unnecessary 1-block. Here is a MWE where I additionaly remove the undesired block:
julia> using KomaMRI julia> seq = Sequence() Sequence[ τ = 0.0 ms | blocks: 1 | ADC: 0 | GR: 0 | RF: 0 | DEF: 0 ] julia> seq += Sequence([Grad(1,1)]) Sequence[ τ = 1000.0 ms | blocks: 2 | ADC: 0 | GR: 1 | RF: 0 | DEF: 0 ] julia> seq = seq[2:end] Sequence[ τ = 1000.0 ms | blocks: 1 | ADC: 0 | GR: 1 | RF: 0 | DEF: 0 ]
This should't have implications in the simulations, however is not the behaviour we expect.
The text was updated successfully, but these errors were encountered:
This could fix it
Sequence() = Sequence(Matrix{Grad}(undef, 3, 0))
or defne
struct EmptySequence end Sequence() = EmptySequence() +(::EmptySequence, seq::Sequence) = ... +(::EmptySequence, seq::RF) = ... +(::EmptySequence, seq::Grad) = ... +(::EmptySequence, seq::ADC) = ...
Sorry, something went wrong.
More efficient Seq constructor, and fix #203
c505bb2
Fixed #203
682af57
Successfully merging a pull request may close this issue.
When an empty sequence is created, it adds an unnecessary 1-block. Here is a MWE where I additionaly remove the undesired block:
This should't have implications in the simulations, however is not the behaviour we expect.
The text was updated successfully, but these errors were encountered: