Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comm_info_reply should not be sent on IOPub #1000

Open
twavv opened this issue Apr 7, 2021 · 2 comments · May be fixed by #1138
Open

comm_info_reply should not be sent on IOPub #1000

twavv opened this issue Apr 7, 2021 · 2 comments · May be fixed by #1138

Comments

@twavv
Copy link
Contributor

twavv commented Apr 7, 2021

IJulia sends the comm_info_reply message (in response to comm_info_request) on the IOPub channel, but it should be sent as a reply on the shell channel.

https://jupyter-client.readthedocs.io/en/stable/messaging.html#comm-info
@stevengj
Copy link
Member

stevengj commented Apr 8, 2021

Whoops, can you make a PR?

@twavv
Copy link
Contributor Author

twavv commented Apr 8, 2021

Sure. :)

Is there any way I could get commit permissions for the repo? I'm happy to go through the PR process and whatnot, but there have been a number of things languishing for a while (e.g., #859, #946)

@halleysfifthinc halleysfifthinc linked a pull request Dec 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jupyter messaging updates/correctness halleysfifthinc/IJulia.jl
2 participants
@twavv @stevengj