You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the code in Backenddispatch_hook is kind of messy. I guess it made sense when there was only a single back end. To be more specific, I would like for us to decide what should be done about exceptions. Currently we simply catch all the exceptions and log them but I wonder if this is the right approach to take. Previously, the method also caught some back end specific errors but that was lost with the move to multiple back ends.
What are your thoughts on the matter?
The text was updated successfully, but these errors were encountered:
The reason why i was catched all these different exceptions here was just to have some statistic at the beginning.
I wanted to know if a hook failed because of a KeyError exception (so the hook implementation was faulty), or if libvmi failed to read the memory, or even if the memory access was not consistent (dump test on ObjectAttributes fields).
This self.stats was just to give me some visibility after running Nitro.
My idea here would be to replace that code by a generic exception handler, to catch everything.
It's critically important to catch any exception that could be raised while a hook is being processed.
Otherwise we are not ackowledging the kernel and the VM is frozen and has to be killed
Currently, the code in
Backend
dispatch_hook is kind of messy. I guess it made sense when there was only a single back end. To be more specific, I would like for us to decide what should be done about exceptions. Currently we simply catch all the exceptions and log them but I wonder if this is the right approach to take. Previously, the method also caught some back end specific errors but that was lost with the move to multiple back ends.What are your thoughts on the matter?
The text was updated successfully, but these errors were encountered: