diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8292db34b..d0344aa05 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -248,7 +248,12 @@ jobs: export DISPLAY=:99 sleep 3 - name: Run Playwright tests - run: DEBUG=pw:browser* npx playwright test --retries=2 --trace retain-on-first-failure --project electron + run: | + echo "start" + echo $DISPLAY + echo "end" + export DISPLAY=:99 + DEBUG=pw:browser* npx playwright test --retries=2 --trace retain-on-first-failure --project electron # run: DEBUG=pw:browser* xvfb-run -e /dev/stdout npx playwright test --retries=2 --trace retain-on-first-failure --project electron - uses: actions/upload-artifact@v4 if: ${{ !cancelled() }} diff --git a/gui/entry_point/main.js b/gui/entry_point/main.js index acf1fecf9..885b3589e 100644 --- a/gui/entry_point/main.js +++ b/gui/entry_point/main.js @@ -46,6 +46,7 @@ function createWindow() { }) mainWindow.once('ready-to-show', () => { + // TODO: put this back conditionnally // mainWindow.show() }) } diff --git a/tests/playwright/project_electron_param.ts b/tests/playwright/project_electron_param.ts index 618827707..f89c8462f 100644 --- a/tests/playwright/project_electron_param.ts +++ b/tests/playwright/project_electron_param.ts @@ -25,9 +25,11 @@ export const test = test_base.extend({ console.info("Setting up electron app"); const electronApp = await electron.launch({ args: [ - "--ignore-gpu-blacklist", "--enable-logging", + "--ignore-gpu-blacklist", + "--enable-logging", electron_app_entry_point_path - ], executablePath: electron_exe_path + ], + executablePath: electron_exe_path }); // TODO: remove?