Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspect ratio of Publisher Logos #3451

Open
Saetron opened this issue Dec 10, 2024 · 2 comments
Open

Aspect ratio of Publisher Logos #3451

Saetron opened this issue Dec 10, 2024 · 2 comments
Labels
needs-triage Needs to be triaged by a developer and assigned a release

Comments

@Saetron
Copy link

Saetron commented Dec 10, 2024

What happened?

In some cases, publishers may not have a square logo. This can lead to their logos being displayed in unexpected ways, such as this:
Image

What did you expect?

It was expected that publisher logos would be constrained by height rather than width. This would result in a display similar to the following:
Image

Kavita Version Number - If you don not see your version number listed, please update Kavita and see if your issue still persists.

0.8.4.2 - Stable

What operating system is Kavita being hosted from?

Docker (Dockerhub Container)

If the issue is being seen on Desktop, what OS are you running where you see the issue?

Windows

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Firefox, Chrome

If the issue is being seen on Mobile, what OS are you running where you see the issue?

Android

If the issue is being seen on the Mobile UI, what browsers are you seeing the problem on?

Chrome

Relevant log output

No response

Additional Notes

No response

@Saetron Saetron added the needs-triage Needs to be triaged by a developer and assigned a release label Dec 10, 2024
@majora2007
Copy link
Member

@therobbiedavis what is your take on this since you implemented the original idea?

@therobbiedavis
Copy link
Collaborator

therobbiedavis commented Dec 11, 2024

@therobbiedavis what is your take on this since you implemented the original idea?

@majora2007 A few thoughts here:

  1. I am not keen on having the image and the text, it should be one or the other. If there is an image, hide the text then we can put the text in a popover. If there is no image, show the text.
  2. To make things uniform we need to need to specify one dimension, either height or width, not both. Most of our cover repo comic publisher images are 64x64 but that's not the case for manga and we can't always expect users to follow that. I think we should constrain the height (64px), and not the width (100%), but set a max-width maybe at like 200px or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Needs to be triaged by a developer and assigned a release
Projects
None yet
Development

No branches or pull requests

3 participants