Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperMarioBros-v3 environment color conflicts #109

Open
dman82499 opened this issue Jan 4, 2022 · 2 comments
Open

SuperMarioBros-v3 environment color conflicts #109

dman82499 opened this issue Jan 4, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@dman82499
Copy link

dman82499 commented Jan 4, 2022

In SuperMarioBros-v3 (rectangle environment), the floor is the exact same color as the goombas, making it very hard for computer vision systems to differentiate the floor as being separate from goombas. I'm not sure if such a fix (such as slightly altering the color of goombas) could be implemented, as I have not looked at the implementation for the rectangle environment. However, if it is possible to implement this fix, I would be willing to try and submit a PR. That being said, I just wanted to confirm with the owners of the repo first if this should be considered a bug.

@Kautenja
Copy link
Owner

Kautenja commented Jan 4, 2022

Hi thanks for the bug report. I was not aware of this, but would label it as undesired functionality for sure in the context of computer vision research. Could you provide the exact level where this occurs and maybe a screenshot so I can grab the color codes? Thanks!

@Kautenja Kautenja added the bug Something isn't working label Jan 4, 2022
@dman82499
Copy link
Author

dman82499 commented Jan 5, 2022

Hello, thanks for the reply and willingness to help! I have observed the color issue on just the 1-1 level, but theoretically it could occur at any level where the mean ground color is similar to the mean goomba color. I believe that that particular described scenario happens in the above ground, below ground, and castle levels, so this could potentially be an issue in a lot of levels (although I have not explicitly confirmed or investigated this yet). Here is a picture of what this looks like in 1-1.
mario

I confirmed that the goomba and ground color matched R=298, G=92, B=16 through sampling. In addition, I used a Connected Component Algorithm to confirm that the ground and goombas are both the same color and connected to each other (pixels share the same neighbor).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants