Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rollback https://github.com/KipData/FnckSQL/pull/191 #252

Merged
merged 1 commit into from
Dec 7, 2024
Merged

chore: rollback https://github.com/KipData/FnckSQL/pull/191 #252

merged 1 commit into from
Dec 7, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Dec 7, 2024

What problem does this PR solve?

this feature is not fully supported for the time being, and will be rolled back to pr 191 to avoid affecting user use.

link: #192

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould added the invalid This doesn't seem right label Dec 7, 2024
@KKould KKould self-assigned this Dec 7, 2024
@KKould KKould force-pushed the chore/rollback_pr_191 branch from ec853f3 to fa09b7c Compare December 7, 2024 06:06
@KKould KKould mentioned this pull request Dec 7, 2024
Open
4 tasks
@KKould KKould merged commit d857919 into main Dec 7, 2024
6 checks passed
@KKould KKould deleted the chore/rollback_pr_191 branch December 8, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KKould KKould

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KKould