-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maxSnippetSize parameter #128
Comments
I checked and there are actually two limits: one is character based, one is token based. The match has a token based limit, which makes sense for annotation data retrieval. so we may want to have |
Thanks for checking, Nils! Does whereas |
No - maxMatchTokenSize doesn't include the context and maxContextCharSize is a maximum value for left and right context. There is no maximum snippet size, as we allow to cut matches and still allow to view the context. I can't remember the concrete reason, it may have been just simpler to implement. But it also has some advantages. Krawfish will have some difficulties with character sizes in contexts, but I think we can keep this feature. So - do you want to have the context adjustable only? |
Thanks for the clarification! We have discussed this over Slack and agree to allow adjustment for both variables. |
Change-Id: I8c542a7fb5406b9bb7d08b909114a99348ff84e9
Change-Id: I8c542a7fb5406b9bb7d08b909114a99348ff84e9
Change-Id: I81eacce8fb0991ed2c2470950f36cfbc02b9ea7f
Uploaded patch set 7. Outdated Votes: * Code-Review+1 (copy condition: "changekind:NO_CHANGE OR is:MIN") Patch-set: 7 Subject: Make match size configurable (address #128) Commit: 524e318 Tag: autogenerated:gerrit:newPatchSet Groups: 524e318 Attention: {"person_ident":"Gerrit User 19 \u003c19@626241b7-b7d0-4197-b843-1ee23887649c\u003e","operation":"ADD","reason":"Vote got outdated and was removed: Code-Review+1"}
Change-Id: I8c542a7fb5406b9bb7d08b909114a99348ff84e9
Change-Id: Ieef96dd68adf4e3ce00f59fc21face545c2ce897
Change-Id: Ieef96dd68adf4e3ce00f59fc21face545c2ce897
Uploaded patch set 2. Outdated Votes: * Code-Review+1 (copy condition: "changekind:NO_CHANGE OR is:MIN") Patch-set: 2 Subject: Make match and context size configurable (address #128) Commit: 9b8ec14 Tag: autogenerated:gerrit:newPatchSet Groups: 9b8ec14 Attention: {"person_ident":"Gerrit User 21 \u003c21@626241b7-b7d0-4197-b843-1ee23887649c\u003e","operation":"ADD","reason":"Vote got outdated and was removed: Code-Review+1"}
Uploaded patch set 3. Outdated Votes: * Code-Review+1 (copy condition: "changekind:NO_CHANGE OR is:MIN") Patch-set: 3 Subject: Make match and context size configurable (address #128) Commit: 464ae45 Tag: autogenerated:gerrit:newPatchSet Groups: 464ae45 Attention: {"person_ident":"Gerrit User 19 \u003c19@626241b7-b7d0-4197-b843-1ee23887649c\u003e","operation":"ADD","reason":"Vote got outdated and was removed: Code-Review+1"}
Change-Id: Ieef96dd68adf4e3ce00f59fc21face545c2ce897
Please add a new parameter to allow Kustvakt to change the snippet size beyond limit. It is necessary to support larger match context for a group of users see (KorAP/Kustvakt#745)
The parameter should be exclusive for Kustvakt and not adjustable by users.
The text was updated successfully, but these errors were encountered: