Adding Collection Rewrite to an existing collection

[margaretha]

If a KoralQuery contains a collection property, Kustvakt adds collection/availability rewrites within the existing collection.

For corpus query corpusSigle=WPD17, Kustvakt replaces koral:doc to koral:docGroup

Before rewrite:

"collection" : {
    "@type" : "koral:doc",
    "match" : "match:eq",
    "value" : "WPD17",
    "key" : "corpusSigle"
  },
  "@context" : "http://korap.ids-mannheim.de/ns/koral/0.3/context.jsonld"

After rewrite:

{
  "@context": "http://korap.ids-mannheim.de/ns/KoralQuery/v0.3/context.jsonld",
  "collection": {
    "@type": "koral:docGroup",
    "operands": [
      {
        "@type": "koral:doc",
        "key": "availability",
        "match": "match:eq",
        "type": "type:regex",
        "value": "CC.*"
      },
      {
        "@type": "koral:doc",
        "key": "corpusSigle",
        "match": "match:eq",
        "value": "WPD17",
        "type": "type:string"
      }
    ],
    "operation": "operation:and",
    "rewrites": [
      {
        "@type": "koral:rewrite",
        "operation": "operation:insertion",
        "scope": "availability(FREE)",
        "src": "Kustvakt"
      }
    ]
  },

Theoretically the rewrites should be placed at the same level at collection with operation:override instead.

Suggestion 1

{
  "@context": "http://korap.ids-mannheim.de/ns/KoralQuery/v0.3/context.jsonld",
  "collection": {
    "@type": "koral:docGroup",
    "operands": [
      {
        "@type": "koral:doc",
        "key": "availability",
        "match": "match:eq",
        "type": "type:regex",
        "value": "CC.*"
      },
      {
        "@type": "koral:doc",
        "key": "corpusSigle",
        "match": "match:eq",
        "value": "WPD17",
        "type": "type:string"
      }
    ],
    "operation": "operation:and"
  },
  "rewrites": [
    {
      "@type": "koral:rewrite",
      "operation": "operation:override",
      "scope": "collection",
      "src": "Kustvakt",
      "origin": "Kustvakt",
      "source" : 
        {
          "@type" : "koral:doc",
          "match" : "match:eq",
          "value" : "WPD17",
          "key" : "corpusSigle"
       }
    }
  ]

Alternatively, the rewrites can be placed within collection and it should include deletions as follows. But it is rather verbose.

Suggestion 2

{
  "@context": "http://korap.ids-mannheim.de/ns/KoralQuery/v0.3/context.jsonld",
  "collection": {
    "@type": "koral:docGroup",
    "operands": [
      {
        "@type": "koral:doc",
        "key": "availability",
        "match": "match:eq",
        "type": "type:regex",
        "value": "CC.*"
      },
      {
        "@type": "koral:doc",
        "key": "corpusSigle",
        "match": "match:eq",
        "value": "WPD17",
        "type": "type:string"
      }
    ],
    "operation": "operation:and",
    "rewrites": [
      {
        "@type": "koral:rewrite",
        "operation": "operation:injection",
        "src": "Kustvakt"
        "origin": "Kustvakt"
      },
      {
        "@type" : "koral:rewrite",
        "src" : "Kustvakt",
        "origin" : "Kustvakt",
        "operation" : "operation:deletion",
        "scope" : "@type",
        "source" : "koral:doc"
      },
      {
        "@type" : "koral:rewrite",
        "src" : "Kustvakt",
        "origin" : "Kustvakt",
        "operation" : "operation:deletion",
        "scope" : "match",
        "source" : "match:eq"
      },
      {
        "@type" : "koral:rewrite",
        "src" : "Kustvakt",
        "origin" : "Kustvakt",
        "operation" : "operation:deletion",
        "scope" : "value",
        "source" : "WPD17"
      },
      {
        "@type" : "koral:rewrite",
        "src" : "Kustvakt",
        "origin" : "Kustvakt",
        "operation" : "operation:deletion",
        "scope" : "key",
        "source" : "corpusSigle"
      }
    ]
  }
}

See also #782

[Akron]

I think the first version is better, although the parsing/marking is a bit more complicated. But adding a rewrite to the next higher unchanged element seems to be reasonable.

[margaretha]

Adding the rewrite at one level higher turns out to be more complicated when there are multiple rewrites and a rewrite is done on top of a rewritten node, see #780 .

[margaretha]

The 2nd option can be simplified as follows:

{
    "@context": "http://korap.ids-mannheim.de/ns/KoralQuery/v0.3/context.jsonld",
    "collection": {
        "@type": "koral:docGroup",
        "operands": [
            {
                "@type": "koral:doc",
                "key": "availability",
                "match": "match:eq",
                "type": "type:regex",
                "value": "CC.*"
            },
            {
                "@type": "koral:doc",
                "key": "corpusSigle",
                "match": "match:eq",
                "value": "WPD17",
                "type": "type:string"
            }
        ],
        "operation": "operation:and",
        "rewrites": [
            {
                "@type": "koral:rewrite",
                "operation": "operation:override",
                "src": "Kustvakt",
                "origin": "Kustvakt",
                "source": {
                    "@type": "koral:doc",
                    "match": "match:eq",
                    "value": "WPD17",
                    "key": "corpusSigle"
                }
            }
        ]
    }
}