Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SparseCtrl/experimental is awesome, what is its status? #151

Open
aihopper opened this issue Aug 12, 2024 · 2 comments
Open

SparseCtrl/experimental is awesome, what is its status? #151

aihopper opened this issue Aug 12, 2024 · 2 comments

Comments

@aihopper
Copy link

aihopper commented Aug 12, 2024

This module https://github.com/Kosinkadink/ComfyUI-Advanced-ControlNet/blame/68e5cd41e43cf0ec0a052167ef2c1c1bfb3aac7d/adv_control/nodes_sparsectrl.py#L69 i believe takes a controlnet(i.e: ) and converts it into a sparsectrl, this is gold!

What is its status?

In order to use it I had to remove motion_holder from https://github.com/Kosinkadink/ComfyUI-Advanced-ControlNet/blame/68e5cd41e43cf0ec0a052167ef2c1c1bfb3aac7d/adv_control/nodes_sparsectrl.py#L84

Should I expect correct results?

edit: OK it looks like this needs some more fixes that I am still trying to figure out, but any help is welcome! :)

@aihopper aihopper changed the title SparseCtrl/experimental is gold, what is status? SparseCtrl/experimental is awesome, what is its status? Aug 13, 2024
@Kosinkadink
Copy link
Owner

This was an experimental feature to see if there was any possible utility in using normal controlnet weights alongside the motion modules contained in SparseCtrl models, but all experimentation by me and other peeps in the community only produced god awful results, not sure you could even call it "working".

I wasn't aware that the node stopped working though. I'll look into it at some point to get it working again, if its broken currently.

@aihopper
Copy link
Author

(back from vacation, sorry for the delay) I very much appreciate your update as this saved me a lot of time trying to make it work. It looked like a good approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants