Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[comfyui-art-venture bug] No module named 'control' #50

Open
Aljnk opened this issue Jan 3, 2024 · 8 comments
Open

[comfyui-art-venture bug] No module named 'control' #50

Aljnk opened this issue Jan 3, 2024 · 8 comments
Labels
external node bug Bug is in another node pack. no bugs here Not a bug, but a workflow or environment issue

Comments

@Aljnk
Copy link

Aljnk commented Jan 3, 2024

Hi. When I start my ComfyUI I see your message "No module named 'control'" from ComfyUI-Advanced-ControlNet\control\control.py

Screenshot_1
@Kosinkadink
Copy link
Owner

Maybe Visual Studio does not like relative python imports, but Visual Studio Code is fine with it. I am able to run and debug ComfyUI code within Visual Studio Code, and everything works fine when running normally.

At some point I'll try to run through Visual Studio to confirm, but it's not high on my priority list. Let me know if you find out anything else in your experimentation, such as if there is a way Visual Studio expects relative imports to be written, or if an init.py file within the control folder would fix it.

This is the way I do relative imports in all of my comfy nodes (AnimateDiff-Evolved, Advanced-ControlNet, VideoHelperSuite), so I'm not sure what it's issue could be. Might also be worth trying to change the name of the control directory in case it gets confused about a folder and a Python file inside it both being called control.

Let me know the results! If it's something as simple as changing the control directory name to fix the issue in Visual Studio, I can make that change quickly.

@Kosinkadink Kosinkadink changed the title No module named [Visual Studio debugging] No module named 'control' Jan 4, 2024
@Aljnk
Copy link
Author

Aljnk commented Jan 5, 2024

The problem is not only in Visual Studio - I see this message every time I start my ComfyUI in CMD.

Screenshot_1

How to fix it? Hm... I'll try to find the way and let you know as soon as possible.

@Kosinkadink
Copy link
Owner

I don't think anyone else has this issue (I would have gotten a crapton of reports about it), so something might be off with your setup specifically. Can you post a screenshot of your custom_nodes folder, information about your environment etc?

@Aljnk
Copy link
Author

Aljnk commented Jan 5, 2024

The problem is that this error is very hard to find - as you can see, this is not an exception and there is no error text at all in the code. I really struggled to find it :)

PS. To be honest, I don't really understand who writes this error at all - I found all occurrences of the text "No module named..." in the code (there are about 60 of them) - I changed and tested them - and none of them give this error.

@Aljnk
Copy link
Author

Aljnk commented Jan 5, 2024

I found a problem :) - there is a conflict with another plugin, I will test it now and write more info about it.

@Aljnk
Copy link
Author

Aljnk commented Jan 5, 2024

The problem is with "comfyui-art-venture" - it tries to load your node, and seems to do so crookedly or redundantly.

Sorry to bother you!

@Kosinkadink Kosinkadink changed the title [Visual Studio debugging] No module named 'control' [comfyui-art-venture bug] No module named 'control' Jan 16, 2024
@Kosinkadink Kosinkadink added no bugs here Not a bug, but a workflow or environment issue external node bug Bug is in another node pack. labels Jan 16, 2024
@darkwinpro
Copy link

darkwinpro commented Jan 28, 2024

image
image

Same, after uninstall Art-Venture:
image

@MAXadobeX
Copy link

do you solve it?

Hi. When I start my ComfyUI I see your message "No module named 'control'" from ComfyUI-Advanced-ControlNet\control\control.py

Screenshot_1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external node bug Bug is in another node pack. no bugs here Not a bug, but a workflow or environment issue
Projects
None yet
Development

No branches or pull requests

4 participants