Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin version of Sail used #382

Closed
adam-cattermole opened this issue Dec 15, 2023 · 3 comments · Fixed by #402
Closed

Pin version of Sail used #382

adam-cattermole opened this issue Dec 15, 2023 · 3 comments · Fixed by #402
Assignees
Labels
area/dependencies Changes dependencies
Milestone

Comments

@adam-cattermole
Copy link
Member

We currently install from the https://github.com/maistra/istio-operator/tree/maistra-3.0 branch directly which results in any downstream changes potentially breaking our install (see #380). We should look to pin the version that we install alongside the image that we use.

That being said, it's worth considering that when installing from the community operators on OpenShift currently the only available build is the most recent nightly build. If we pin to a version and don't test frequently on OpenShift, changes could be made that would break our compatibility without our knowledge.

@adam-cattermole adam-cattermole added the area/dependencies Changes dependencies label Dec 15, 2023
@adam-cattermole adam-cattermole moved this to Todo in Kuadrant Jan 8, 2024
@adam-cattermole
Copy link
Member Author

adam-cattermole commented Jan 8, 2024

The release of the sail operator without a floating tag should be completed as part of OSSM-5547

@adam-cattermole
Copy link
Member Author

For the time being while we are awaiting for a stable version of sail we will revert to local install defaulting to using istioctl. So that we are still aware of the changing requirements of sail without slowing down active development we can move the integration test (sail) to a nightly scheduled run instead of a hard requirement for PR's.

@adam-cattermole
Copy link
Member Author

Until we find a way forward with #401 I'll pin to the latest nightly that still had the kustomize manifests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Changes dependencies
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants